From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] libnotmuch: fix typo in CLEAN setting, add file
In-Reply-To: <1308912824-1709-1-git-send-email-david@tethera.net>
References: <1308912824-1709-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Fri, 24 Jun 2011 10:51:51 -0700
Message-ID: <87aad7ce2w.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: David Bremner <bremner@debian.org>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 24 Jun 2011 07:53:44 -0300, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>

Hi David,

Thanks for the fix. A couple of nit-picky comments on the commit itself
first:

> - c0961e6 introduced a missing slash and
> - cdf1c70a created a file and neglected to add it to clean

I'd put a little more detail in the commit message here:

=2D c0961e6 introduced a missing slash $(dir)$(LIBNAME)
=2D cdf1c70a created $(dir)/notmuch.h.gch and neglected to add it to clean

> The former seems to have been harmless, so maybe someone (Carl?) can
> check if $(dir)/$(LIBNAME) really needs to be removed?

This auxiliary text should be below the "---" line in the email so that
it won't be in the commit message after I do "git am". (As is, I'd have
to do extra work to "git commit --amend" this text away).

As for the actual question, yes, $(dir)/$(LIBNAME) is supposed to be
cleaned and is not getting cleaned. I've got libnotmuch.so.1.{1,2,3,4}.0
all sitting around never cleaned.

> -CLEAN :=3D $(CLEAN) $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINK=
ER_NAME) $(dir)$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym
> +CLEAN +=3D $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME)
> +CLEAN +=3D $(dir)/$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym=20

Meanwhile, I notice now that "libnotmuch.a" is also wrong, (should be
"$(dir)/libnotmuch.a).

Clearly we could use some testing of our "make clean" target to ensure
it actually works. Does the Debian stuff not test anything like this?
(Maybe I'm thinking of typical testing done by autoconf/automake's "make
distcheck" that we haven't replicated yet.)

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4EzrcACgkQ6JDdNq8qSWgK7ACfU/seIsV4PHvqjyhyxk0jB3AM
75sAnjKkjX+Ccn+Z0Nydp0LaMcziXh2N
=Vmdn
-----END PGP SIGNATURE-----
--=-=-=--