Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6FF10431FC0 for ; Sun, 1 Apr 2012 15:45:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OIQvDHcqU-Rm for ; Sun, 1 Apr 2012 15:45:53 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id F1B4A431FAF for ; Sun, 1 Apr 2012 15:45:52 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id A2D4E328017; Sun, 1 Apr 2012 15:45:52 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (unknown [76.89.193.65]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id E3C6D32800C; Sun, 1 Apr 2012 15:45:49 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 911CC906; Sun, 1 Apr 2012 15:45:49 -0700 (PDT) From: Jameson Graef Rollins To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag) In-Reply-To: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com> References: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.12+87~g3c4c85f (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 01 Apr 2012 15:45:46 -0700 Message-ID: <87bonb5aw4.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2012 22:45:53 -0000 --=-=-= On Sat, Mar 31 2012, Mark Walters wrote: > This is version 2 of the exclude= series (version 1 is [1]). > > The main changes are the addition of some systematic notmuch-search > tests for all the exclude options, and I no longer add the > exclude=flag option to notmuch-show.c (the output was too similar to > exclude=false to be worth keeping). Thanks so much for staying on top of this series. I think this is a really important new feature and I really appreciate you ferrying it all the way through to the finish line. These changes are critical to the functionality as well, as the exclude stuff currently causes severe performance degradation. So this is all very welcome. I've been using a previous version of this series for weeks now with no problems at all. The emacs UI is snappy again. This new version applies cleanly to the current master, and all tests pass. And in my cursory review everything LGTM. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJPeNqbAAoJEO00zqvie6q8BkwQAKwVBCixf1B4vIrtFcww32Vb oZzYnBXnAG2NlTxInZR1cR+r7+hrloFFxHugtzFzVeSg6525DMIzg2PLV8G8Unzu 40zYcWO7od4Lk5JBn/lLSddfeqogF42Jr85XMpIqdLVCK29Pzdu8o17ZkLhXSosW hwCsEdUjWGpr0uFgejZZ8oKqFndhvS7Movtef2pkuIx1ef5MS6NilAoTv9VsPaP4 Y5L7xr6mdpYpplLN9UsI+T9KuD4qKIEfhOkhnNT0Ko0XCieOaTMCf1AO2h4sCPUw bm+D/42NerHbZDYiQVK+nsaEQXFb+YZ/kdlO0jJTqR0Gr9AQCFcltuO3H87IfZon k2ECobBGYiW4cGtlheWB4oyztmeMBlqyNezXFyZCGE4vTcEaCks5XvMRCNiK28vA 5h9nI7cnsEd+gjhF2bPktz5H/ntLY7dKyhAy47o0U6irQSn+3mqDNqEhHSgF2f+3 7l2BadLx1qzSFgLhhEfSGBEbj2XXz/pRIXNDDJBwhyuLcdW6CWKH71lroUyoSGb5 ntGAQv0bIOOhQsNLpG/LqIZE8OG8kFia4pI5lzy4bHMtS+CHoi6Ex9c5s14HfMnT bNaMli+N0s0945XoCX0cwNBqtCwdgmE2KitLFRJ/5M+ut5oumyfIczY+r5S6pn9d RmvhIlFfP/EAK9K3l8+j =CHJL -----END PGP SIGNATURE----- --=-=-=--