From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, David Edmondson <dme@dme.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Correct the documentation
	for	`notmuch-search-line-faces'.
In-Reply-To: <m2siomhi4g.fsf@guru.guru-group.fi>
References: <cun8uqffdo1.fsf@hotblack-desiato.hh.sledj.net>
	<1399370610-7146-1-git-send-email-dme@dme.org>
	<m2siomhi4g.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Tue, 06 May 2014 19:52:58 +0100
Message-ID: <8738gmu4c5.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


LGTM too +1

Mark

On Tue, 06 May 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, May 06 2014, David Edmondson <dme@dme.org> wrote:
>
>> The implementation and documentation for `notmuch-search-line-faces'
>> disagreed in how elements in the list were merged. Correct the
>> documentation to match the implementation (that is, the earlier
>> elements in the list have precedence over later elements).
>
> LGTM.
>
> Tomi
>
>
>
>> ---
>>  emacs/notmuch.el | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index 6c0bc1b..8aa0104 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -647,12 +647,12 @@ of the result."
>>  Here is an example of how to color search results based on tags.
>>   (the following text would be placed in your ~/.emacs file):
>>  
>> - (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>> -						  :background \"blue\"))
>> -                                   (\"unread\" . (:foreground \"green\"))))
>> + (setq notmuch-search-line-faces '((\"unread\" . (:foreground \"green\"))
>> +                                   (\"deleted\" . (:foreground \"red\"
>> +						  :background \"blue\"))))
>>  
>> -The attributes defined for matching tags are merged, with later
>> -attributes overriding earlier. A message having both \"deleted\"
>> +The attributes defined for matching tags are merged, with earlier
>> +attributes overriding later. A message having both \"deleted\"
>>  and \"unread\" tags with the above settings would have a green
>>  foreground and blue background."
>>    :type '(alist :key-type (string) :value-type (custom-face-edit))
>> -- 
>> 2.0.0.rc0
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch