From: Aaron Ecay <aaronecay@gmail.com>
To: Robert Horn <rjhorn@alum.mit.edu>, notmuch@notmuchmail.org
Subject: Re: bug related to ical
In-Reply-To: <m31ul3qo4w.fsf@quad.robs.office>
References: <m31ul3qo4w.fsf@quad.robs.office>
User-Agent: Notmuch/0.14+25~g0721c93 (http://notmuchmail.org) Emacs/24.2.50.4
	(x86_64-unknown-linux-gnu)
Date: Wed, 26 Sep 2012 02:36:34 -0400
Message-ID: <87d319b899.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

The problem is in the =E2=80=98notmuch-show-insert-part-text/calendar=E2=80=
=99
function.  The call to =E2=80=98icalendar--convert-ical-to-diary=E2=80=99 d=
oes not
create a buffer visiting the temp file, so the call to =E2=80=98set-buffer=
=E2=80=99
fails.  The following patch fixes the problem.

The ical->diary conversion also doesn=E2=80=99t seem to work =E2=80=93 the =
calendar
attachment shows up as an empty part =E2=80=93 but I guess that=E2=80=99s a=
 separate
issue (and not addressed by the patch).

I guess that part insertion handlers should be called inside a
=E2=80=98condition-case=E2=80=99, so that an error inside of one can be rec=
overed from,
and doesn=E2=80=99t entirely derail the insertion of the messages in the bu=
ffer.
(I actually made this patch because I was so annoyed that Olivier=E2=80=99s
buggy test attachment made it impossible for me to read Tomi=E2=80=99s repl=
y.)

----- cut here -----

diff --git i/emacs/notmuch-show.el w/emacs/notmuch-show.el
index ce5ea6f..4c89d7e 100644
--- i/emacs/notmuch-show.el
+++ w/emacs/notmuch-show.el
@@ -746,7 +746,7 @@ message at DEPTH in the current thread."
 	      (icalendar--convert-ical-to-diary
 	       (icalendar--read-element nil nil)
 	       file t)
-	      (set-buffer (get-file-buffer file))
+	      (set-buffer (find-file-noselect file))
 	      (setq result (buffer-substring (point-min) (point-max)))
 	      (set-buffer-modified-p nil)
 	      (kill-buffer (current-buffer))

----- cut here -----

--=20
Aaron Ecay