Return-Path: <dme@dme.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 1D4C0431FBD
	for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:07:09 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Z2i0yYmXzf08 for <notmuch@notmuchmail.org>;
	Tue, 13 May 2014 03:07:01 -0700 (PDT)
Received: from mail-we0-f173.google.com (mail-we0-f173.google.com
	[74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id E48F6431FAF
	for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:07:00 -0700 (PDT)
Received: by mail-we0-f173.google.com with SMTP id u57so123503wes.32
	for <notmuch@notmuchmail.org>; Tue, 13 May 2014 03:06:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:to:subject:in-reply-to:references:user-agent
	:from:date:message-id:mime-version:content-type;
	bh=UZUrSSUDZlB4J7j0QRMSG7LqpZVHQhH569M81j9ignA=;
	b=UPwqg3U0DRIO5VaV3enbNcL0hHXfjC988J8e1jlwBep9L9XWFEEQazgdDB5npPnjUa
	rkmTY4OYsGI378BpLfc/QU1q33NEakdiY64takddHvJQYBtJhFz2Xqd9ERW4Qnxu2G+c
	M+AZYJzbEtRqrbHOVNvxAZ18m0J069uXyHVD3r/69nP+aQxJ/WubwnT5VDKwHv4wjVIf
	pvhE7vISqRTZVOVZ8Ao3f4Ksb72oTERMS2dYpyTmfVNHZs8mvRp0mA/Ot2NUbH3Gsh/h
	IkHBxkCg+gNGWIxPNJ5I6dL91ARAeNiu8iiT7oeL+8grTzsmBoAj/NN7F5ebtdVGYNKb
	K44A==
X-Gm-Message-State:
 ALoCoQk5Eec3J5ryKiOzLroFUPL/GWnvOFlr/QFSCxGZVu9EpNq8Vl6soSDSO88TlsI1GLE+4yuz
X-Received: by 10.194.84.101 with SMTP id x5mr2264080wjy.52.1399975619774;
	Tue, 13 May 2014 03:06:59 -0700 (PDT)
Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])
	by mx.google.com with ESMTPSA id fi2sm21077084wib.2.2014.05.13.03.06.58
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 13 May 2014 03:06:58 -0700 (PDT)
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 4/9] emacs/mua: Generate improved cited text for
 replies
In-Reply-To: <87egzyk4u2.fsf@qmul.ac.uk>
References: <87sixdujkv.fsf@qmul.ac.uk>
	<1399897769-26809-1-git-send-email-dme@dme.org>
	<1399897769-26809-5-git-send-email-dme@dme.org>
	<87egzyk4u2.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 13 May 2014 11:06:53 +0100
Message-ID: <cunr43y56wy.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2014 10:07:09 -0000

--=-=-=
Content-Type: text/plain

On Mon, May 12 2014, Mark Walters wrote:
> On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:
>> Use the message display code to generate message text to cite in
>> replies.
>
> So this is the key change. I am trying to work out what the actual
> changes are here: in your commit message for the test update 7/9 you say
> that the old code only output the first part. My impression of the
> deleted code is that that is not the case (but I don't grok cl very
> well).

The comment in the test change was intended only to refer to the content
displayed in that specific test. You are correct that text from several
parts could previously have been used (and all smashed together in a way
that made it difficult to see the boundaries between the parts...).

> I think the test change is because in show we do some content-type
> guessing of application/octet-stream which the below doesn't do.
>
> But we may also have some things with mm-inlined-types as mentioned in
> my earlier reply. Anyway if you can point out any other cases where it
> is changed that would be great.

message/rfc822 was the initial driver. If you now reply to a
multipart/mixed that contains text/plain and message/rfc822 parts, you
will see a significant difference.

I'm not sure if you have it, but
id:mailman.1.1399324386.31850.notmuch@notmuchmail.org was the message I
used often when playing around.

> If you go for a function deciding which parts to include then it might
> be possible to have a midpoint where we are the same as before, and then
> tweak the function to get whatever behaviour we think is best. That
> might make it easy to see what is tidying/unification and what is
> enhancement.

I will look into that - it's a good suggestion, though it actually runs
counter to:

> Incidentally, thank you for splitting this series so finely: I did find
> that made it a lot easier to review.

Making the new code (which relies on the 'show' rendering code) behave
just like the old code will involve adding a bunch of complication to
this specific patch.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iKYEARECAGYFAlNx7r1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5
RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYfGACfWo7Sw394a9dEXVGFYVhT3Iw0
pf0An3NpM1lAemnMdty6v/85b4ocRkFc
=QXWj
-----END PGP SIGNATURE-----
--=-=-=--