Date: Wed, 9 May 2012 14:07:00 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Subject: Re: Last minute fixes to the go bindings
Message-ID: <20120509180700.GA11804@mit.edu>
References:
 <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To:
 <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

LGTM.

Quoth Justus Winter on May 09 at 12:23 pm:
> Hi everyone :)
> 
> this is a small patch series that I'd like to see included in 0.13.
> 
> The first patch updates notmuch-addrlookup with respect to Austins
> recent change of the notmuch_database_open function. This fixes the
> compilation of the utility.
> 
> The second patch fixes the values of all the STATUS_* constants. Turns
> out all of them were set to zero by accident. This isn't a c style
> enum, golang has the iota operator to do this kind of stuff. This
> fixes the error handling for all the users of the go bindings.

'Doh!  Is it possible to get the status values out of cgo, rather than
depending on the list in libnotmuch and the list in Go being in the
same order?

> The third patch just brings the list of status constants up to date.
> 
> Cheers,
> Justus