From: Carl Worth <cworth@cworth.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test: use `princ' instead of `message' calls in emacs
	tests
In-Reply-To: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com>
References: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Fri, 27 May 2011 16:12:20 -0700
Message-ID: <87tycfrb57.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> The patch replaces all (message (buffer-string)) calls in emacs
> tests with (princ (buffer-string)).  This avoids accidentally
> interpreting '%' as format specifiers and makes code simpler
> because we do not need to capture stderr.
>=20
> Also, the patch works around an Emacs (23.3+1-1 on current Debian
> Unstable) segfault in "Ensure that emacs doesn't drop results"
> test.

Thanks so much for the fix! I hadn't noticed the segfault until the
recent additional include of test-lib.el, (which of course shouldn't
actually be changing anything), which seems to tickle the emacs bug a
little more frequently for me at least.

The segfault made it obvious that this was an emacs bug, but it was
annoying to hit. It will be nice to have this fix in place.

This change is pushed now.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3gL9QACgkQ6JDdNq8qSWjoxgCgjsQyK7F4wTABYe4kTrhmi56g
Q+kAmwTZGdwvPcOHCIwy7uVNIk0qT6Da
=ZPtG
-----END PGP SIGNATURE-----
--=-=-=--