From: David Bremner <david@tethera.net>
To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org
Subject: Re: [bug] notmuch requires Content-Disposition mime header value to
 be lower case
In-Reply-To: <20150918123724.1941.3900@localhost>
References: <20150917070056.1941.94846@localhost>
 <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost>
 <87pp1grl2v.fsf@maritornes.cs.unb.ca> <20150918123724.1941.3900@localhost>
User-Agent: Notmuch/0.20.2+61~g005c2f0 (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Fri, 18 Sep 2015 10:26:00 -0300
Message-ID: <871tdvvoyf.fsf@tesseract.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Johannes Schauer <josch@debian.org> writes:

> Hi,
>
> Quoting David Bremner (2015-09-18 14:03:20)
>> I'd recommend making your own new test, rather than modifying existing
>> ones to test multiple things.  I'd also recommend using json / sexp
>> output for your tests, since the ad-hoc text format is kindof
>> semi-deprecated.
>
> can you take care of that? My goal was actually just to report this bug, not to
> spend more time to develop a proper patch for it :)

Consider the bug reported. At the moment I'm not completely convinced
the patch is correct, never mind the tests. I agree it looks obvious
enough, but the test results don't make sense to me yet.

>
> Also, a related problem occurs when the Content-Disposition header contains
> UTF8 characters, in which case the header value gets encoded. Apparently
> notmuch does not attempt to decode it. Example mime header:
>
> --===============7161366892858136962==
> Content-Type: application/pdf
> MIME-Version: 1.0
> Content-Transfer-Encoding: base64
> Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
>  =?utf-8?b?LnBkZiI=?=

yes, that sounds like a distinct bug.