From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/4 v2] test: `notmuch-test-run' should protect against
	buffer switching.
In-Reply-To: <1327506328-22126-3-git-send-email-dme@dme.org>
References: <1327503908-17226-1-git-send-email-dme@dme.org>
	<1327506328-22126-1-git-send-email-dme@dme.org>
	<1327506328-22126-3-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 25 Jan 2012 21:36:04 +0400
Message-ID: <87obtrhegr.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 25 Jan 2012 15:45:26 +0000, David Edmondson <dme@dme.org> wrote:
> The body of the test may cause the current buffer to change. Ensure
> that the output goes to the correct buffer by switching back before
> inserting it.

LGTM

Regards,
  Dmitry

> ---
>  test/test-lib.el |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 36e793a..0efb02a 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -89,7 +89,9 @@ nothing."
>  (defmacro notmuch-test-run (&rest body)
>    "Evaluate a BODY of test expressions and output the result."
>    `(with-temp-buffer
> -     (let ((result (progn ,@body)))
> +     (let ((buffer (current-buffer))
> +	   (result (progn ,@body)))
> +       (switch-to-buffer buffer)
>         (insert (if (stringp result)
>  		   result
>  		 (prin1-to-string result)))
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch