Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 4B0D8431FC7
	for <notmuch@notmuchmail.org>; Wed, 21 Aug 2013 04:27:17 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TyOu3X0N7B4j for <notmuch@notmuchmail.org>;
	Wed, 21 Aug 2013 04:27:07 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 9545B431FC2
	for <notmuch@notmuchmail.org>; Wed, 21 Aug 2013 04:27:07 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id B9ABF100086;
	Wed, 21 Aug 2013 14:26:57 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] timegm: add portable implementation (Solaris support)
In-Reply-To: <1377083394-29755-1-git-send-email-Vladimir.Marek@oracle.com>
References: <m2eh9sn8cm.fsf@guru.guru-group.fi>
	<1377083394-29755-1-git-send-email-Vladimir.Marek@oracle.com>
User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 21 Aug 2013 14:26:57 +0300
Message-ID: <m238q3ffni.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Vladimir Marek <vlmarek@volny.cz>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2013 11:27:17 -0000

On Wed, Aug 21 2013, Vladimir.Marek@oracle.com wrote:

> From: Blake Jones <blakej@foo.net>
>
> The timegm(3) function is a non-standard extension to libc which is
> available in GNU libc and on some BSDs.  Although SunOS had this
> function in its libc, Solaris (unfortunately) removed it.  This patch
> implements a very simple version of timegm() which is good enough for
> parse-time-string.c.
>
> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
> ---

Thanks, LGTM.

>  compat/Makefile.local                 |    4 +++
>  compat/compat.h                       |    5 +++
>  compat/have_timegm.c                  |    7 +++++
>  compat/timegm.c                       |   56 +++++++++++++++++++++++++++++++++
>  configure                             |   11 +++++++
>  parse-time-string/parse-time-string.c |    1 +
>  6 files changed, 84 insertions(+)
>  create mode 100644 compat/have_timegm.c
>  create mode 100644 compat/timegm.c
>