From: Jani Nikula <jani@nikula.org>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: bug in emacs reply code?
In-Reply-To: <87r4we3wp7.fsf@nikula.org>
References: <87r4we3wp7.fsf@nikula.org>
User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1
	(i686-pc-linux-gnu)
Date: Wed, 28 Mar 2012 10:13:05 +0000
Message-ID: <87obrh3ufi.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 27 Mar 2012 15:11:48 +0000, Jani Nikula <jani@nikula.org> wrote:
> 
> Hi all, just upgraded from 0.11 to master on one machine, and emacs
> reply started failing as follows. The four tests fail, all others pass.
> 
> $ emacs --version
> GNU Emacs 23.2.1

I bisected the problem to commit "emacs: Use the new JSON reply format
and message-cite-original" 650123510cfa64caf6b20f5239f43433fa6f2941.

Following up Adam's suggestion, it boils down to a change in emacs
message-mail function in lisp/gnus/message.el. If I eval-defun the
message-mail from 23.3, the UI seems to work. The diff between the
versions is below. That bit of elisp is beyond me, please look into it.

BR,
Jani.

--- emacs-23.2/lisp/gnus/message.el     2010-04-23 17:59:51.000000000+0300
+++ emacs-23.3/lisp/gnus/message.el     2011-11-26 05:20:20.000000000+0200
[...]
@@ -6487,7 +6513,13 @@
     (message-setup
      (nconc
       `((To . ,(or to "")) (Subject . ,(or subject "")))
-      (when other-headers other-headers))
+      ;; C-h f compose-mail says that headers should be specified as
+      ;; (string . value); however all the rest of message expects
+      ;; headers to be symbols, not strings (eg message-header-format-alist).
+      ;; http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00337.html
+      ;; We need to convert any string input, eg from rmail-start-mail.
+      (dolist (h other-headers other-headers)
+       (if (stringp (car h)) (setcar h (intern (capitalize (car h)))))))
      yank-action send-actions continue switch-function)
     ;; FIXME: Should return nil if failure.
     t))
@@ -8189,5 +8221,4 @@
[...]