Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 97E664196F4 for ; Fri, 23 Apr 2010 17:53:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sGm82zmw4ppo; Fri, 23 Apr 2010 17:53:18 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DC9924196F3; Fri, 23 Apr 2010 17:53:17 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 8B8F2568DEC; Fri, 23 Apr 2010 17:53:17 -0700 (PDT) From: Carl Worth To: Ben Gamari , notmuch Subject: Re: [PATCH] Fix linker error from insufficient LDFLAGS In-Reply-To: <1271974827-10978-2-git-send-email-bgamari.foss@gmail.com> References: <1271974827-10978-1-git-send-email-bgamari.foss@gmail.com> <1271974827-10978-2-git-send-email-bgamari.foss@gmail.com> User-Agent: Notmuch/0.2-173-gbae184f (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Fri, 23 Apr 2010 17:53:17 -0700 Message-ID: <8739yloema.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Apr 2010 00:53:18 -0000 --=-=-= On Thu, 22 Apr 2010 18:20:27 -0400, Ben Gamari wrote: > It seems that LDFLAGS have recently been reorganized, along with the > introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used > in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking > to fail with the following, What system is this on? > -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch > +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS) > FINAL_NOTMUCH_LINKER = CC > ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) > FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) Note that CONFIGURE_LDFLAGS *is* conditionally added a couple of lines later. In my testing on Linux, these flags aren't needed/wanted for linking notmuch-shared. And I believe I tested the conditional assignment such that it gets enabled on OS X at least, where these additional flags are needed. So perhaps you've just got a system where we need to detect that LINKER_RESOLVES_LIBRARY_DEPENDENCIES should be set to 0? Let me know, -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFL0kD96JDdNq8qSWgRAqTOAJwOZedRLy96BDkLbqky2/C08zQCCgCgilHK OInlYUS9c3gLWAMta0X3VKI= =0y+g -----END PGP SIGNATURE----- --=-=-=--