From: Tomi Ollila <tomi.ollila@iki.fi>
To: Thomas Schwinge <thomas@schwinge.name>, notmuch@notmuchmail.org
Subject: Re: [PATCH] dump: Don't sort.
In-Reply-To: <87r51ab36z.fsf@zancas.localnet>
References: <1319884657-5574-1-git-send-email-thomas@schwinge.name>
	<87r51ab36z.fsf@zancas.localnet>
User-Agent: Notmuch/0.10~rc1+16~gc832dad (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Mon, 21 Nov 2011 13:04:18 +0200
Message-ID: <yf6sjlhn3d9.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 14 Nov 2011 21:10:44 -0400, David Bremner <david@tethera.net> wrote:
> On Sat, 29 Oct 2011 12:37:37 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
> > From: Thomas Schwinge <thomas@schwinge.name>
> > 
> > This improves usage experience considerably in the given scenario.
> > 
> 
> I'm not sure if I mentioned this only in IRC, so let me recap.
> 
> Personally, I think this needs more information in the commit message,
> and (optionally) less in the comment. I would prefer to be able to
> understand what is going on just from the output of git log.

I agree; the git commit message:

--8<----8<----8<----8<----8<----8<----8<----8<----8<--
dump: Don't sort.

This improves usage experience considerably in the given scenario.
--8<----8<----8<----8<----8<----8<----8<----8<----8<--

Is not very informative. Better to describe the given scenario in commit
message and (perhaps!) tune the comment in the code.

We've seen that the patch is very useful -- So, Thomas, please provide a 
patch in a format it can be comfortably added to the repository :).

> 
> d

Tomi