Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 8AEE4431FC0
	for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:06:54 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id fekfjVMx167Q for <notmuch@notmuchmail.org>;
	Sat,  4 Jan 2014 05:06:46 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id A59C2431FBD
	for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:06:46 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 26F931000B2;
	Sat,  4 Jan 2014 15:06:39 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Thomas Klausner <tk@giga.or.at>
Subject: Re: notmuch-0.16: realpath() compatibility issue;
	clang visibility problem
In-Reply-To: <20140104125358.GW27614@danbala.tuwien.ac.at>
References: <20140103214735.GG27614@danbala.tuwien.ac.at>
	<CAB+hUn-8eyY07y3j1N3JJLQ3qWVEVPoGWHcUVkovg34xH0ZOwQ@mail.gmail.com>
	<sfid-H20140104-134644-+055.78-1@spamfilter.osbf.lua>
	<CAB+hUn-ov+2roT-tVTcjuPbckiTkRPtUxazfmY1KFeeVoMQJCA@mail.gmail.com>
	<20140104125358.GW27614@danbala.tuwien.ac.at>
User-Agent: Notmuch/0.17+13~gdfcf116 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 04 Jan 2014 15:06:38 +0200
Message-ID: <m2eh4n521t.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Notmuch Mail <notmuch@notmuchmail.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jan 2014 13:06:54 -0000

On Sat, Jan 04 2014, Thomas Klausner <tk@giga.or.at> wrote:

> On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote:
>> I guess we should look at realpath() compatibility, but in fairness passing
>> NULL for the second parameter is according to POSIX.1-2008, not glibc
>> extension.
>
> Ah, interesting.
>
> I can file a bug report with NetBSD about that, but in the meantime,
> it causes a coredump. :|

The linux namual page (*) has good explanation of this in the BUGS section

(*) http://man7.org/linux/man-pages/man3/realpath.3.html


After reading that I think fixing that is not as simple as your previous
patch does it -- so probably you just have to keep patching your system
until NetBSD library realpath() is POSIX.1-2008 -compatible.

Note that having users' own patches in their systems is not uncommon
at all :D


>
> Thanks,
>  Thomas

Tomi