From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH v2] emacs: Make the part content available to the
	mm-inline* checks.
In-Reply-To: <20120118193501.GG16740@mit.edu>
References: <1326907993-11054-1-git-send-email-dme@dme.org>
	<1326908371-11949-1-git-send-email-dme@dme.org>
	<877h0o99aj.fsf@gmail.com>
	<cunlip47tir.fsf@hotblack-desiato.hh.sledj.net>
	<874nvs96ps.fsf@gmail.com> <20120118193501.GG16740@mit.edu>
User-Agent: Notmuch/0.11+73~g8a5402e (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 18 Jan 2012 23:59:03 +0400
Message-ID: <87zkdk7pfc.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jan 18 at 11:00 pm:
> > On Wed, 18 Jan 2012 18:30:36 +0000, David Edmondson <dme@dme.org> wrote:
> > > On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > > On Wed, 18 Jan 2012 17:39:31 +0000, David Edmondson <dme@dme.org> wrote:
> > > > > The `mm-inlinable-p' and `mm-inlined-p' functions work better if they
> > > > > have access to the data of the relevant part, so load that content
> > > > > before calling either function.
> > > > > 
> > > > > This fixes the display of attached image/jpeg parts, for example.
> > > > 
> > > > Not so long ago I made an opposite change to avoid fetching useless
> > > > parts (e.g. audio files).  Looks like we need a better check here.  Can
> > > > we know from Content-Type if fetching a part body would be useful?
> > > 
> > > What if `notmuch-show-insert-part-*/*' consulted a list of content-type
> > > regexps to attempt to inline?
> > > 
> > > That would allow a sane default (("image/*" "text/*") perhaps), but also
> > > allow more to be added to that list (or some to be removed), either by
> > > code that detected the (in)ability to render it or the user.
> > 
> > Perhaps there is such a list in mm already?
> 
> Shouldn't we only be doing this for parts with inline (or not
> attachment) content-disposition?  That's cheap to check.  Or do we
> actually want things like image attachments to get inlined, despite
> their disposition?

It may be good to have this behavior configurable.  I would like Emacs
to display all part types that it can, independent from
content-disposition.

Anyway, this is a separate issue.  In any case we want to fetch part
body only if it is useful.

Regards,
  Dmitry