Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 84390431FAF
	for <notmuch@notmuchmail.org>; Thu, 20 Dec 2012 08:58:30 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4gW05sZiqJ6M for <notmuch@notmuchmail.org>;
	Thu, 20 Dec 2012 08:58:29 -0800 (PST)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 902D2431FAE
	for <notmuch@notmuchmail.org>; Thu, 20 Dec 2012 08:58:29 -0800 (PST)
Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
	([156.34.82.78] helo=zancas.localnet)
	by tesseract.cs.unb.ca with esmtpsa
	(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
	(envelope-from <bremner@unb.ca>)
	id 1TljRx-0004k7-Fm; Thu, 20 Dec 2012 12:58:26 -0400
Received: from bremner by zancas.localnet with local (Exim 4.80)
	(envelope-from <bremner@unb.ca>)
	id 1TljRr-0004kf-UW; Thu, 20 Dec 2012 12:58:19 -0400
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] CLI: add talloc leak report,
	controlled by an environment variable.
In-Reply-To: <m2hangivfu.fsf@guru.guru-group.fi>
References: <1355714648-23144-1-git-send-email-david@tethera.net>
	<1355714648-23144-2-git-send-email-david@tethera.net>
	<m2hangivfu.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.14+163~g11a220a (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Thu, 20 Dec 2012 12:58:19 -0400
Message-ID: <87hang8xuc.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2012 16:58:30 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Dec 17 2012, david@tethera.net wrote:
>
>> From: David Bremner <bremner@debian.org>
>>
>> The argument handling in notmuch.c seems due for an overhaul, but
>> until then use an environment variable to specify a location to write
>> the talloc leak report to.  This is only enabled for the (interesting)
>> case where some notmuch subcommand is invoked.
>> ---
>
> I'd still suggest to have similar command-line interface option(s) as
> samba4 use: --leak-report and/or --leak-report-full
>
> (search --leak-r in talloc(3) namual page)
>

Sure sounds fine, when someone (TM) redoes the top level argument
handling. I think it would make sense to ditch the alias handling
completely; both current aliases are deprecated for a long time.

d