From: Tomi Ollila <tomi.ollila@iki.fi>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch dump: default to batch-tag format.
In-Reply-To: <1390311688-1491-1-git-send-email-david@tethera.net>
References: <1390311688-1491-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.17+34~g98b959f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Tue, 21 Jan 2014 15:58:43 +0200
Message-ID: <m24n4xo2r0.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, Jan 21 2014, david@tethera.net wrote:

> From: David Bremner <david@tethera.net>
>
> Although we didn't formally deprecate the old format, the new one has
> been available for a year.
> ---
>  NEWS           | 10 ++++++++++
>  notmuch-dump.c |  2 +-
>  2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index 28788d8..bdb248e 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,3 +1,13 @@
> +Notmuch 0.18 (2014-xx-xx)
> +=========================

I tried to advocate Notmuch 0.18 (UNRELEASED) during last development
cycle -- in followu ========================= p patch (if any -- 
with manpage change) this change could also be made.

> +
> +Command-Line Interface
> +----------------------
> +
> +`notmuch dump` now defaults to `batch-tag` format.
> +
> +  The old format is still available with `--format=sup`.
> +
>  Notmuch 0.17 (2013-12-30)
>  =========================
>  
> diff --git a/notmuch-dump.c b/notmuch-dump.c
> index f8edda7..158142f 100644
> --- a/notmuch-dump.c
> +++ b/notmuch-dump.c
> @@ -40,7 +40,7 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
>      char *output_file_name = NULL;
>      int opt_index;
>  
> -    int output_format = DUMP_FORMAT_SUP;
> +    int output_format = DUMP_FORMAT_BATCH_TAG;

This part looks good.

>  
>      notmuch_opt_desc_t options[] = {
>  	{ NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f',
> -- 

Tomi