Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AC6DE431FBF for ; Mon, 13 Feb 2012 11:14:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7dNpJE8RqB+J for ; Mon, 13 Feb 2012 11:14:41 -0800 (PST) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id CA104431FBC for ; Mon, 13 Feb 2012 11:14:40 -0800 (PST) Received: by guru.guru-group.fi (Postfix, from userid 501) id 74F2368055; Mon, 13 Feb 2012 21:14:40 +0200 (EET) From: Tomi Ollila To: Daniel Schoepe , Austin Clements , Dmitry Kurochkin Subject: Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively In-Reply-To: <87r4xysgk4.fsf@schoepe.localhost> References: <1329131347-13803-1-git-send-email-dmitry.kurochkin@gmail.com> <20120213152858.GO27039@mit.edu> <87r4xysgk4.fsf@schoepe.localhost> User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2012 19:14:41 -0000 On Mon, 13 Feb 2012 20:02:03 +0100, Daniel Schoepe wrote: > On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements wrote: > > Quoth Dmitry Kurochkin on Feb 13 at 3:09 pm: > > > The notmuch-show view refresh function (`notmuch-show-refresh-view', > > > bound to "=") accepts an optional RETAIN-STATE argument. The patch > > > allows to set this argument interactively by using "C-u =". > > > > Why do we not *always* want this? > > Seconded. And I don't think making that the default along with an easy > way to get the old behavior is "too much" for one patch, even though > "put that in a separate commit!" is a fairly common sentiment here, and > not a bad one, most of the time. I agree. If there is going to be 2 commits, first to change '=' retain state and second to add previous behaviour by adding prefix argument handling. > Cheers, > Daniel tomi