Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BED64431FBD for ; Thu, 4 Mar 2010 00:26:00 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.677 X-Spam-Level: X-Spam-Status: No, score=-0.677 tagged_above=-999 required=5 tests=[AWL=-0.678, BAYES_50=0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wUXjEvNajQDl for ; Thu, 4 Mar 2010 00:26:00 -0800 (PST) Received: from homiemail-a12.g.dreamhost.com (caiajhbdccah.dreamhost.com [208.97.132.207]) by olra.theworths.org (Postfix) with ESMTP id 025C9431FAE for ; Thu, 4 Mar 2010 00:25:59 -0800 (PST) Received: from sspaeth.de (mtec-hg-docking-1-dhcp-204.ethz.ch [129.132.133.204]) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTPA id 76831714060; Thu, 4 Mar 2010 00:25:47 -0800 (PST) Received: by sspaeth.de (sSMTP sendmail emulation); Thu, 04 Mar 2010 09:25:45 +0100 From: "Sebastian Spaeth" To: Ben Gamari , notmuch@notmuchmail.org, cworth@cworth.org In-Reply-To: <1264368215-7101-3-git-send-email-bgamari.foss@gmail.com> References: <1264272821-sup-5331@ben-laptop> <1264368215-7101-1-git-send-email-bgamari.foss@gmail.com> <1264368215-7101-2-git-send-email-bgamari.foss@gmail.com> <1264368215-7101-3-git-send-email-bgamari.foss@gmail.com> Date: Thu, 04 Mar 2010 09:25:45 +0100 Message-ID: <878wa8sdbq.fsf@SSpaeth.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH 2/2] Build and link against notmuch shared library X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 08:26:00 -0000 > notmuch_client_modules = $(notmuch_client_srcs:.c=.o) > -notmuch: $(notmuch_client_modules) lib/notmuch.a > - $(call quiet,CXX,$(LDFLAGS)) $^ $(FINAL_LDFLAGS) -o $@ > +notmuch: $(notmuch_client_modules) lib/libnotmuch.so > + $(call quiet,CC,$(LDFLAGS)) -lnotmuch $(filter-out lib/libnotmuch.so,$^) $(FINAL_LDFLAGS) -o $@ I just tried out this patch to compile notmuch as a shared library and while producing lib/libnotmuch.so.1 it fails to find notmuch later: CC notmuch /usr/bin/ld: cannot find -lnotmuch Aso it creates libnotmuch.so.1 in lib but seems to try symlinking it in the "compat" dir which fails and produces a dead symlink. CXX lib/libnotmuch.so.1 ln -sf compat/libnotmuch.so.1 compat/libnotmuch.so Is more needed than this patch? Also, *I* think it would be nice to support --static or --shared as options to --configure. But that is a minor thing, probably. Sebastian