Return-Path: <dme@dme.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C1DE54196F0
	for <notmuch@notmuchmail.org>; Mon, 26 Apr 2010 03:43:38 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
	tests=[BAYES_00=-1.9] autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id m6ihIijY11li for <notmuch@notmuchmail.org>;
	Mon, 26 Apr 2010 03:43:37 -0700 (PDT)
Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
	[74.125.82.181])
	by olra.theworths.org (Postfix) with ESMTP id A6066431FC1
	for <notmuch@notmuchmail.org>; Mon, 26 Apr 2010 03:43:37 -0700 (PDT)
Received: by wyj26 with SMTP id 26so596410wyj.26
	for <notmuch@notmuchmail.org>; Mon, 26 Apr 2010 03:43:36 -0700 (PDT)
Received: by 10.216.86.209 with SMTP id w59mr4943934wee.186.1272278616790;
	Mon, 26 Apr 2010 03:43:36 -0700 (PDT)
Received: from ut.hh.sledj.net (host83-217-165-81.dsl.vispa.com
	[83.217.165.81])
	by mx.google.com with ESMTPS id t70sm887736weq.2.2010.04.26.03.43.34
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Mon, 26 Apr 2010 03:43:35 -0700 (PDT)
Received: by ut.hh.sledj.net (Postfix, from userid 1000)
	id B2B32594135; Mon, 26 Apr 2010 11:43:45 +0100 (BST)
To: Dirk Hohndel <hohndel@infradead.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] RFC: Add From guessing when forwarding email
In-Reply-To: <m3eii5lr34.fsf@x200.gr8dns.org>
References: <m3eii5lr34.fsf@x200.gr8dns.org>
User-Agent: Notmuch/0.2-191-g4256215 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 26 Apr 2010 11:43:45 +0100
Message-ID: <87och65w9q.fsf@ut.hh.sledj.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2010 10:43:38 -0000

On Fri, 23 Apr 2010 15:52:15 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> Given how little elisp I know I'm quite interested in feedback
> and better implementations

I think that:

(defun notmuch-show-forward-message ()
  "Forward the current message."
  (interactive)
  (let ((user-mail-address
	 (shell-command-to-string (concat notmuch-command
					  "guess-from"
					  (notmuch-show-get-message-id)))))
    (with-current-notmuch-show-message
     (notmuch-mua-forward-message))))

is more idiomatic.

dme.
-- 
David Edmondson, http://dme.org