Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7BCDD429E30 for ; Tue, 14 Feb 2012 09:34:08 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RSlmbH07bOTi for ; Tue, 14 Feb 2012 09:34:07 -0800 (PST) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id 16A35431FBC for ; Tue, 14 Feb 2012 09:34:03 -0800 (PST) X-AuditID: 1209190d-b7fbf6d0000008ba-93-4f3a9b0acfdc Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id C1.00.02234.A0B9A3F4; Tue, 14 Feb 2012 12:34:02 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q1EHY1B0006054; Tue, 14 Feb 2012 12:34:01 -0500 Received: from drake.mit.edu (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [209.6.116.242]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1EHY0cR016524 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 14 Feb 2012 12:34:01 -0500 (EST) Received: from amthrax by drake.mit.edu with local (Exim 4.77) (envelope-from ) id 1RxMGO-00027V-0w; Tue, 14 Feb 2012 12:34:00 -0500 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH 7/8] show: Make format_part_sigstatus_json's API consistent between GMIME 2.4 and 2.6 Date: Tue, 14 Feb 2012 12:33:42 -0500 Message-Id: <1329240823-7856-8-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1329240823-7856-1-git-send-email-amdragon@mit.edu> References: <1329240823-7856-1-git-send-email-amdragon@mit.edu> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsUixG6noss128rf4PJcNYsje2axW1zd2s9u cf3mTGYHZo+ds+6yezxbdYvZo+nHYtYA5igum5TUnMyy1CJ9uwSujDMnRAqmcFd0ve1gbGDs 4+xi5OSQEDCROP13KhuELSZx4d56IJuLQ0hgH6PEoUOnGCGcDYwSL/ddYoJw7jNJNEx4CVU2 n1FiyvsHLCD9bAIaEtv2L2cEsUUEpCV23p3NCmIzC8RLHGlbDxYXFkiV+L3pEFicRUBV4sOc VcwgNq+AvcTyA8uYIO5QkDi3+hw7iM0p4CCxf99/sHohoJpLd7eyTGDkX8DIsIpRNiW3Sjc3 MTOnODVZtzg5MS8vtUjXSC83s0QvNaV0EyMovDgleXcwvjuodIhRgINRiYfXwMLSX4g1say4 MvcQoyQHk5Ior/AMK38hvqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrybpgPleFMSK6tSi/JhUtIc LErivKpa7/yEBNITS1KzU1MLUotgsjIcHEoSvEmzgBoFi1LTUyvSMnNKENJMHJwgw3mAhieD 1PAWFyTmFmemQ+RPMSpKifN6gCQEQBIZpXlwvbD4f8UoDvSKMG8QSBUPMHXAdb8CGswENHj7 aQuQwSWJCCmpBsai/fcYFynGzTJT1XjOfuDbmQ3L9ttK13GeacmSv8MnVB56dV9MbdpCHet/ jfrXJul5ZCZOyPvvn/o5XULw/WqtWxdkhR0yDsScVv305dKCfoP068X+jIL+S3Yce7pEe5f1 /yOv9Kx1bx3qt/IrEGu1bPU+4tDhzrP/Eetz/baVf4+Lp/v9y1diKc5INNRiLipOBAAJampN 2gIAAA== X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2012 17:34:09 -0000 The implementation is still different for GMIME 2.4 and 2.6, but at least now the caller doesn't have to be aware of this. --- notmuch-show.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 8fb6fa6..07276c7 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -404,8 +404,10 @@ signer_status_to_string (GMimeSignerStatus x) #ifdef GMIME_ATLEAST_26 static void -format_part_sigstatus_json (GMimeSignatureList *siglist) +format_part_sigstatus_json (mime_node_t *node) { + GMimeSignatureList *siglist = node->sig_list; + printf ("["); if (!siglist) { @@ -470,8 +472,10 @@ format_part_sigstatus_json (GMimeSignatureList *siglist) } #else static void -format_part_sigstatus_json (const GMimeSignatureValidity* validity) +format_part_sigstatus_json (mime_node_t *node) { + const GMimeSignatureValidity* validity = node->sig_validity; + printf ("["); if (!validity) { @@ -696,11 +700,7 @@ format_part_json (const void *ctx, mime_node_t *node, notmuch_bool_t first) if (node->verify_attempted) { printf (", \"sigstatus\": "); -#ifdef GMIME_ATLEAST_26 - format_part_sigstatus_json (node->sig_list); -#else - format_part_sigstatus_json (node->sig_validity); -#endif + format_part_sigstatus_json (node); } printf (", \"content-type\": %s", -- 1.7.7.3