Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DE2F2431FBF; Sat, 21 Nov 2009 15:23:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6CNc+sf4V+Gb; Sat, 21 Nov 2009 15:23:26 -0800 (PST) Received: from cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6C06D431FAE; Sat, 21 Nov 2009 15:23:25 -0800 (PST) From: Carl Worth To: Stefan Schmidt , notmuch@notmuchmail.org In-Reply-To: <20091121221702.GG24602@excalibur.local> References: <20091121221702.GG24602@excalibur.local> Date: Sun, 22 Nov 2009 00:23:13 +0100 Message-ID: <87ljhz31jy.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH] notmuch-config: Fix memleaks. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Nov 2009 23:23:27 -0000 On Sat, 21 Nov 2009 23:17:02 +0100, Stefan Schmidt wrote: > > While talloc is great we need to free the g_error by hand. > > Tested-by: Stefan Schmidt > Signed-off-by: Holger Freyther Thanks to both of you! This is pushed. As for talloc and glib, it's become clear to me that I'd really like a talloc-friendly hash-table implementation, (and maybe a nice growing array). I really haven't seen any other data structures in glib that I'd need as universally as I need those, (particularly since talloc already provides a bunch of string functions). -Carl