Sender: Michal Nazarewicz <mpn@google.com>
From: Michal Nazarewicz <mina86@mina86.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/6] emacs: add helper for tag change list manipulation
In-Reply-To:
 <9dbf16fb95f40812ad246f95b954681bc895ceb2.1346614915.git.jani@nikula.org>
Organization: http://mina86.com/
References: <cover.1346614915.git.jani@nikula.org>
	<9dbf16fb95f40812ad246f95b954681bc895ceb2.1346614915.git.jani@nikula.org>
User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Mon, 03 Sep 2012 13:33:55 +0200
Message-ID: <xa1tipbvwdb0.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Jani Nikula <jani@nikula.org> writes:
> Add a helper to create (and optionally reverse) a list of tag changes.
> ---
>  emacs/notmuch-tag.el |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 0c0fc87..c1aeb99 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -140,6 +140,23 @@ notmuch-after-tag-hook will be run."
>    ;; in all cases we return tag-changes as a list
>    tag-changes)
>=20=20
> +(defun notmuch-tag-change-list (tags &optional reverse)
> +  "Convert TAGS into a list of tag changes.
> +
> +Add a \"+\" prefix to any tag in TAGS list that doesn't already
> +begin with a \"+\" or a \"-\". If REVERSE is non-nil, replace all
> +\"+\" prefixes with \"-\" and vice versa in the result."
> +  (mapcar (lambda (str)
> +	    (let ((s (if (not (string-match "^[+-]" str))
> +			 (concat "+" str)
> +		       str)))

(if (string-match "^[-+]" str) str (concat "+" str))

Negation only makes things less readable IMO.

> +	      (if reverse
> +		  (concat (if (=3D (string-to-char s) ?-) "+" "-")
> +			  (substring s 1))
> +		s)))
> +	  tags))
> +
> +
>  ;;
>=20=20
>  (provide 'notmuch-tag)

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQRJWjAAoJECBgQBJQdR/0HCgP/2QaZyjEqq9PP/8YoUqx7zUY
9U9AoP+f7hxjT4387Fpm4HOFSw6cKK4jxGKZQ97v7vFKf0tLaIp18bosHHGSoX29
nuDP2tvwo4Psuih17yV9STzHkaSCgaFPa27s/baTYIvFP2iD7CX0d7W2H+LIaYFl
fIFVuLHLMWH5PqGXaE5vu3I1wXK07L8YwjTL4XBvWg3h904S8m/unpINP/XuBOq1
jpIQv5op+EbenXvdFU8t5x8xvdwhIc+plJg02RqB12gXHJMQq0Wp36WX0BaKH34V
huCEBAV3Tv+Ihbm/0Mg8goWsyE3kfZ1hKFwZksnEpuZREmawBDYwL9EaNCt1GE65
eHwL/ZA1xQ1GkhdEuBV6yRldVlYOVNqsiFSM4DffpqUfbLDC8oQSX6aRpX8CQr12
KBDOHBIgpYE+uojMjTeoNHsoF02z3/tsHoCZspm/e6/FYKVBzbTeuDXPBv7st8Qu
cMsIBXMRGKKD7YWRIdF2+nF7rPdOvhGo5k9RAJU5l/3bHyQ7tr4aaZdVUi0feNlE
OxbG32w3zjhBo2LpOHYU/+whylsiipUqsN01tzUvc3aETSeyLz3reQNfSiJhJbGZ
EPDHGlj4kHfdi0zI+IHSbmscRQvC8r29yZCZrUMaHomlMRr+C6+wEYgvsJ6lcj48
xl+Y5CTOs+2vqxXpWyjs
=xmOa
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--