From: Daniel Schoepe <daniel.schoepe@googlemail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 1/2] emacs: User-defined sections in notmuch-hello
In-Reply-To: <87k4bs4gbn.fsf@steelpick.2x.cz>
References: <1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309883030-28899-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309883030-28899-2-git-send-email-daniel.schoepe@googlemail.com>
	<87fwmjabii.fsf@steelpick.2x.cz>
	<87oc17r38a.fsf@tredergarh.home.box>
	<871uy25d3y.fsf@steelpick.2x.cz> <87wrfuc5i6.fsf@gilead.invalid>
	<87k4bs4gbn.fsf@steelpick.2x.cz>
User-Agent: Notmuch/0.5-329-g0b5d38d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 09 Jul 2011 00:03:28 +0200
Message-ID: <87r5602zwu.fsf@gilead.invalid>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 08 Jul 2011 23:23:40 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrot=
e:
> OK. I changed my mind. I thought that the approach with 'notmuch
> search-tags QEURY' followed by 'notmuch count tag:XXX and QUERY' for
> returned tags would be faster then 'notmuch search-tags' followed by
> 'notmuch count tag:XXX and QUERY' for all tags, but it turned out not to
> be the case.

For me, the stronger argument was that the code would have been simpler,
because notmuch-hello refreshes don't happen that often that performance
shouldn't matter much.

>=20
> I played with the customization interface a bit and found the following
> problems:
>=20
> - It is annoying to insert section titles that includes ": " at the end
>   in order to be nicely "rendered". I think this could be appended
>   automatically.

Agreed.

>=20
> - :hide-empty-tags should be renamed in :hide-empty-searches to be
>   effective (see the patch below).

This has been done in v4 of the patch, for which I screwed up the
In-Reply-To header and hence is listed as a separate thread:

id:"1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com"

>=20
> - The title of custom tags section was not passed correctly to the
>   functions. This is also fixed in the patch below.

I changed title to a mandatory argument for consistency with
notmuch-insert-searches and because a title-less section wouldn't make
much sense anyway.

Cheers,
Daniel

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJOF36xAAoJEIaTAtce+Z+Je6MP/RDhXjV/0JFI39foNYGC12LX
VD5nnwFkJb3rF/AGhwIil7HbII2UVbqi+xaug8sfhSy6HDgBzfpl1EMKH1qrk2p/
+tsmgV60Tqz5o9WKXNiiWgXal/XyWnW64+DOAi3GD0m+HmmGpCs1dDZ35EF7TS0C
AiKzWJKcb1ek9c+2h+VyIBhlu8UbmfG5CePSQ2h6j+xCpIH2HhJtY17hpkW4ZjLN
43kVwhvL7OZoWDbVej8RFINvStp4CE+/rhIhaRzH1VEpGjvyieBfPReVxC2zmC0r
QpLS/DwAUlur/Vo720LpA2suUIg8Sst3LuJJy/cJHUKOYqBlVpKDM27NLFMZ8NLX
DhjLxEje5AbN8v9fLOHeNB2p3zmwxOh3hdOjcTe2GBw3go+T2KxH3cfr4YgQektB
QVl2Fq2oCBdcGY/tq5iuJ0aI4DQeLkImL8gBKrnR/qovBmW87ab6I5pPOSBNt2dx
+oklcaAgdujsDv/6Xs1poUaHKzQmyiyEXX0P9j/sjpsl1O1r+rVP7xUnKVn2s5bF
Mi7lkGL7PisJuIFd4mQMB4LdZAYIc0mQWgUIiCpmsoBtGPwdPgrotMr36Qf5a2PK
BFDaCJodz8+wB3N5/Hg0sk+wc4WJrp+8n1ILEvYZLgpLYNE1Iw4ZGNV2SJ6Xzreq
ynCIWGVfyS/9bsEVM6ih
=3nnj
-----END PGP SIGNATURE-----
--=-=-=--