From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag
In-Reply-To: <m27gm2ax1k.fsf@guru.guru-group.fi>
References: <1361399077-7737-1-git-send-email-david@tethera.net>
	<1361399077-7737-2-git-send-email-david@tethera.net>
	<m27gm2ax1k.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Thu, 21 Feb 2013 07:52:18 -0400
Message-ID: <87k3q151fx.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Feb 2013 11:52:30 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

>
> This patch series looks good to me (as far as I can understand, I did
> not find the "silly bug" in your previous patch...)
>

Compare :

+    print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",
+      'id:'.$pair->{id};

vs.

+    print $notmuch $D_action.$TAGPREFIX.$pair->{tag},
+      'id:'.$pair->{id};

I obviously did not test that version very well.

> Instead of mentioning that "calls are _not_ passed to shell" here,
> that could be briefly mentioned just before system() calls in the
> script -- and that definitely should not be 'At the moment' feature.

Sure, the "At the moment" is meant to modify "relies". In the next
patch, we stop relying on this feature of Perl.

>
> the system() function in perl(1) never pass execution through the
> shell in case the args are list more than one arg:
>

right. that's what I meant by "is a documented feature of perl's system
function"

So I think we mean to say the same thing here; but I could I add a
comment in this patch (to delete it in the next). Or maybe reword that
commit message somehow.

d