From: Carl Worth <cworth@cworth.org>
To: dme@dme.org, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch: Fix off-by-one errors if a header is >200
	characters long.
In-Reply-To: <1272451541-6479-1-git-send-email-dme@dme.org>
References: <1272451541-6479-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.3.1-22-g1d528f8 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Thu, 03 Jun 2010 16:48:16 -0700
Message-ID: <87mxvbfzjz.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 28 Apr 2010 11:45:41 +0100, dme@dme.org wrote:
> From: David Edmondson <dme@dme.org>
>=20
> If a single header is more than 200 characters long a set of 'off by
> one' errors cause memory corruption.
...
> This is the cause of my segmentation fault (or bus error) during
> `notmuch reply'. The patch is for the 0.3.1 branch, but I'd expect
> that it will apply cleanly to master.

Thanks for the fix, David.

In my testing I found that it was a header of *exactly* 200 bytes that
caused a problem. I added a message with such a header to the test suite
and verified (with valgrind) that the old code was problematic.

I've now pushed out both your fix and the new test case.

=2DCarl (happy to be hacking on notmuch again)

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMCD9A6JDdNq8qSWgRAutiAJ9VBasMfm7Zk4oKOlUzv/mtuDPs7gCdGCuR
Fn5KuN/v1D3RNpkm/QvF6sA=
=Xv6X
-----END PGP SIGNATURE-----
--=-=-=--