From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default
In-Reply-To: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>
References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Sun, 20 Sep 2015 08:31:16 -0300
Message-ID: <87io75tji3.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Cc: tomi.ollila@iki.fi
Precedence: list

Tomi Ollila <tomi.ollila@iki.fi> writes:

> make test V=1 (or any other value than 0) and make test V=0
> works similar way as build in general
> ---
>
> This is 2nd try: In first one I changed test-lib.sh -- there problem
> was the precedence between command line argument and NOTMUCH_TEST_QUIET
> environment variable. Here I don't see a problem there (although
> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable
> overrule the V=1 -- I am not sure who cares, though :D)
>
> Anyway, Someone(TM) may have better solution in mind, so let's
> get bikeshedding going!
>

One thing I thought of was that we could replace the use of
NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by
the command line argument --verbose.  This would be less work on the
Makefile side, but I guess a bit more on the test-lib.sh side. I suppose
it might also be an annoyance for some people currently using
NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't
think of what would really break by changing this "API", but knows. The
current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely
independent is pretty surprising.

d

P.S. I hope you appreciate my classic "scope-creep" technique in
bikeshedding. ;)