From: Carl Worth <cworth@cworth.org>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Fix to unconditionally display subject changes in
	collapsed thread view
In-Reply-To: <1309510868-27954-1-git-send-email-cworth@cworth.org>
References: <1309510868-27954-1-git-send-email-cworth@cworth.org>
User-Agent: Notmuch/0.6~rc1 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Fri, 01 Jul 2011 02:06:44 -0700
Message-ID: <87oc1egyjf.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: David Bremner <bremner@debian.org>
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri,  1 Jul 2011 02:01:08 -0700, Carl Worth <cworth@cworth.org> wrote:
> Rather than fixing the name of the variable and changing its default
> value, here we remove the condition entirely, such that the feature is
> enabled unconditionally.

I've just pushed this change out.

I emailed it here just to be able to comment on it.

David, I implemented this fix while writing up the NEWS[*] notes for the
0.6 release (and noticing that this feature which was implemented wasn't
actually usable as documented so I couldn't really add a NEWS item for
it).

If you want to sneak it into 0.6 I think it's safe, (it even hits one
existing test case---though an additional test case to show an actual
subject change appearing would be even better).

It's your call of course, and if the change doesn't go, then that's fine
too. In that case, I'll just not comment on this feature in NEWS until
our next release.

=2DCarl

[*] Yes, I'm working away at this=E2=80=94almost done now...

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4NjiQACgkQ6JDdNq8qSWgYxQCgin7il5t1eYQZFgZH3QpHLfyL
Ur4AnR/iuV/HE/0fmtVgOJhwc+tAhDP6
=uYCr
-----END PGP SIGNATURE-----
--=-=-=--