Sender: Nathan Eagleson <nate4d@gmail.com>
From: Nate Eagleson <nate@nateeag.com>
To: "J. Lewis Muir" <jlmuir@imca-cat.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: Support Mac OS X 10.6.8
In-Reply-To: <55940744.7050100@imca-cat.org>
References: <1435699747-13591-1-git-send-email-nate@nateeag.com>
 <1435699747-13591-2-git-send-email-nate@nateeag.com>
 <55940744.7050100@imca-cat.org>
User-Agent: Notmuch/0.20.1+25~g0ab9a1a (http://notmuchmail.org) Emacs/24.4.1
 (i686-apple-darwin)
Date: Thu, 02 Jul 2015 08:05:10 -0400
Message-ID: <m2d20aahop.fsf@nateeag.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

"J. Lewis Muir" <jlmuir@imca-cat.org> writes:

> On 6/30/15 4:29 PM, Nate Eagleson wrote:
>> +# Mac OS X 10.6 has a built-in libutil.dylib that prevents ld from
>> +# picking up notmuch's libutil.a. The best way to prefer our local
>> +# libutil.a is to specify it via absolute path, which should work on
>> +# all supported OSes.
>> +LIBUTIL_PATH=${srcdir}/util/libutil.a
>
> Hi, Nate.
>
> I think it would be better to make the above comment not specific to OS
> X, but instead just refer to "systems that have a built-in util library"
> or similar.  For example, NetBSD has a built-in util library [1].  I
> don't have access to a FreeBSD system, but it looks like FreeBSD might
> have a built-in util library too [2].
>
> Similarly for the one-line commit summary since this change is not
> specific to OS X.
>
> Regards,
>
> Lewis
>
> [1] http://netbsd.gw.com/cgi-bin/man-cgi?libutil++NetBSD-current
> [2] http://svnweb.freebsd.org/base/head/lib/libutil/Makefile?view=markup

Good point. I'll update that.

-Nate