From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: do not hide test_emacs errors
In-Reply-To: <87mxc1mlqm.fsf@rocinante.cs.unb.ca>
References: <1309487028-18786-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87mxc1mlqm.fsf@rocinante.cs.unb.ca>
User-Agent: Notmuch/0.9+55~g81c615b (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 13 Nov 2011 11:06:43 +0400
Message-ID: <87zkg01oxo.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner <david@tethera.net> wrote:
> On Fri,  1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Do not redirect test_emacs stderr to /dev/null.  Test_emacs uses
> > emacsclient(1) now and it does not print unwanted messages (like
> > those from `message') to stderr.  But it does print useful
> > errors, e.g. when emacs server connection fails, given expression
> > is not valid or undefined function is called.
> 
> Is this patch still relevant now that we use dtach to run the tests?
> 

It is still relevant.  If test_emacs prints any errors, we should see
them.  If it does not, we should remove the redirection.

But we need to check for other similar cases.  New test cases may have
been added with test_emacs stderr redirect.

> I didn't notice any difference, but maybe I was not supposed to.
> 

I think that is expected.

Regards,
  Dmitry

> d