Content-Type: multipart/mixed; boundary="===============2021153055585812822=="
MIME-Version: 1.0
References:
 <1323860305-15802-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<1323860305-15802-7-git-send-email-4winter@informatik.uni-hamburg.de>
	<yf6obvbs5j5.fsf@taco2.nixu.fi>
To: Tomi Ollila <tomi.ollila@iki.fi>,  notmuch@notmuchmail.org
In-Reply-To: <yf6obvbs5j5.fsf@taco2.nixu.fi>
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Subject: Re: [PATCH 6/7] py3k: Add and use a mixin class that implements
	__str__
Date: Wed, 14 Dec 2011 13:56:50 +0100
Message-Id: <E1RaoOA-0007ka-G7@thinkbox.jade-hamburg.de>
Precedence: list

--===============2021153055585812822==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Quoting Tomi Ollila (2011-12-14 13:26:38)
>On Wed, 14 Dec 2011 11:58:24 +0100, Justus Winter <4winter@informatik.uni-=
hamburg.de> wrote:
>> ---
>[ ... snip ... ]
>
>>  =

>> -class Filenames(object):
>> +class Filenames(Python3StringMixIn):
>>      """Represents a list of filenames as returned by notmuch
>>  =

>>      This object contains the Filenames iterator. The main function is
>> @@ -98,9 +98,6 @@ class Filenames(object):
>>  =

>>          self._files =3D None
>>  =

>> -    def __str__(self):
>> -        return unicode(self).encode('utf-8')
>> -
>>      def __unicode__(self):
>>          """Represent Filenames() as newline-separated list of full paths
>>  =

>> diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuc=
h/globals.py
>> index c52790c..2111b86 100644
>> --- a/bindings/python/notmuch/globals.py
>> +++ b/bindings/python/notmuch/globals.py
>> @@ -28,6 +28,16 @@ except:
>>      raise ImportError("Could not find shared 'notmuch' library.")
>>  =

>>  =

>> +if sys.version_info[0] =3D=3D 2:
>> +    class Python3StringMixIn(object):
>> +        def __str__(self):
>> +            return unicode(self).encode('utf-8')
>> +else:
>> +    class Python3StringMixIn(object):
>> +        def __str__(self):
>> +            return self.__unicode__()
>> +
>> +
>
>[ ... snip ... ]
>
>> -class Threads(object):
>> +class Threads(Python3StringMixIn):
>>      """Represents a list of notmuch threads
>>  =

>>      This object provides an iterator over a list of notmuch threads
>> @@ -393,7 +393,7 @@ class Thread(object):
>>          return Tags(tags_p, self)
>>  =

>>      def __str__(self):
>> -        return unicode(self).encode('utf-8')
>> +        return self.__unicode__().encode('utf-8')
>>  =

>>      def __unicode__(self):
>>          frm =3D "thread:%s %12s [%d/%d] %s; %s (%s)"
>
>Is this class special case ? in all other classes
>the __str__() function has been removed (using inherited
>function) ?

Damn, I missed that one... that was my first approach but that
obviously didn't worked out... I'll send an updated patch.

>Otherwise LGTM -- pretty simple and effective (all 7 patches).

Thanks :)

Note that I do not know how complete the port is. But the stuff used
by my tagging application (afew) works.

Justus

--===============2021153055585812822==
Content-Type: application/octet-stream
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=".signature"

bG92ZSB1IGFsb3QgQCxACgo=

--===============2021153055585812822==--