Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 98800429E5B for ; Mon, 23 Jan 2012 00:52:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XTXtmGWkE2bS for ; Mon, 23 Jan 2012 00:52:32 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 120C6429E54 for ; Mon, 23 Jan 2012 00:52:32 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id B3F8566E00AE; Mon, 23 Jan 2012 00:52:31 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com [76.174.137.84]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id EEE0F66E00E3; Mon, 23 Jan 2012 00:52:28 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 28F91AF4; Mon, 23 Jan 2012 00:52:29 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327052612-1040-2-git-send-email-dme@dme.org> <877h0jmn9a.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 23 Jan 2012 00:52:26 -0800 Message-ID: <87ipk22439.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Cc: notmuch X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 08:52:32 -0000 --=-=-= On Mon, 23 Jan 2012 08:16:03 +0000, David Edmondson wrote: > There was no problem with the logic. The code in the two functions was > almost identical, so I'd like to make any future changes in just one > place. > > You didn't actually answer my question - is the logic in the new > function correct? Honestly I didn't look too closely yet since I'm not convinced we need the change at all. I would prefer to keep the functions separate. In my opinion, enough special casing would be required that it wouldn't be worth it, and it would make the code less clear. > I'll merge the first patch into the later (and presumably get accused of > submitting patches which include multiple distinct changes :-)). But if you're removing all the code anyway, it's not a distinct change. It's still just a replacement. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPHR/KAAoJEO00zqvie6q8H7gP/0K1ekDHsNVmvvisLTDeR1/b jG/RX5pxtxg0r/OQBnGzLXnEYEI4bmthwbOHdOrlr8GSBQYYA9YA1RCNcKseIxfT DtLuvSpqNhii3U2W5Rhh0OGoZHLVNSgL7J6uh4CYIe/jnVZFg/9IHJVVxupmlH4N X1T1xBPOXFV9JhP/oUg46jRpCrApdU08slF3vT//nRuapnurSCdRGx7206g1+55h dnOwolFNlxGm6xodftt+VKD280XdBVTmVg/cKrvTrLYrnru6KRy6opsUz9/3RA+j HdH4zFhchP2Oj5lgnd5ZU/c+hxbRo4cQLnLsAOXVc/ua+bmcCHNX9QH1PnYteKjU 5mOzCgmg523K8/rEO9XxDR2njBnSxL159ArBB/Am+Wism1VvOGSiT+3YxrRt+npD j9sfyyhfQXYthPRKecP091fTJX2tpO7KOP8d7eXyEJYZGImIogE18G4V/GXuWv6E 0utIurYNehDS9Qn+mbP7JlOR0DR5714BUj0P+YuggdkXcEAeE4PH1enhsCIUiym6 4qY3Sdoh7Ogi5IcKLzlJxAAowgLm2u6LyIJzKK+UJfXYCMgv+CUWO5dASQt26xuD 6YoF30quhRhiwVjwEll0INONJdrjnNelfVQte2AltPaNvPTF8brniPveKE3bpSlC ywU881Ep4FjJO9ioS9Qe =Lbaw -----END PGP SIGNATURE----- --=-=-=--