Resent-Date: Tue, 09 Jul 2013 11:49:26 +0200
Resent-Message-Id: <E1UwUY2-0001Qr-71@thinkbox.jade-hamburg.de>
From: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Subject: [notmuch] Unicode in Python bindings
User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 07 Jul 2013 09:00:16 +0200
Message-ID: <87txk6zwfz.fsf@raeviah.aidecoe.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Resent-From: Justus Winter <4winter@informatik.uni-hamburg.de>
Resent-To: notmuch mailing list <notmuch@notmuchmail.org>
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hello,

I have come across a problem with Unicode [1] in afew mail filter which
uses Notmuch Python bindings and it has eventually bringed us to
confusion about Unicode handling in Python bindings.

Shouldn't __unicode__() methods return value of type unicode?  Let's
take an example of __unicode__() method from Message class:

    def __unicode__(self):
        format =3D "%s (%s) (%s)"
        return format % (self.get_header('from'),
                         self.get_tags(),=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20
                         date.fromtimestamp(self.get_date()),
                        )

format is of type str, not unicode and method is eventually going to
return str, while the user of the API is expecting unicode type.

I haven't programmed in Python 3, yet - only in Python 2, so maybe I am
missing something.  When I was writing a big project in Python 2, I have
eventually decided to use u'' literals everywhere and decode any str to
unicode ASAP - and this solved all issues wrt encodings.  I guess that
mixing Python 2 and 3 gets even more problematic.

Could you review (and fix if it is needed) Python bindings in context of
unicode handling, please?


[1] https://github.com/teythoon/afew/issues/36


Regards,

=2D-=20
Amadeusz =C5=BBo=C5=82nowski

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQEcBAEBAgAGBQJR2RIAAAoJEPATRTHh2/q1jeEH/2+RY69kyuKNz7gdBY5IvKrV
f1WYHMeGkHFcWMC6Rm6dbaXrzfJe6IP7XW+3MaWNErbfsBQzRiUdI+DPPUQZOpI9
KVFCx1wa4jtBrf++kUowV3GlKGyyoDr8W9Gii8wnAw7rRRX9Qv4CP0sNhxXLj5xR
WcmjFLGvuEUXUVZZCAqKfpuXa+BA/ix1gPSfHEK3Gr8TkKbsFzR2GGZxpyq+znsq
NrYBLcD2zAP9UUQ+WVKpo8+x9y++WnEkduWqDX2exvUhHl2u3Rl6co0Mg03/HtSQ
1Bb7MbbATEDC1KD7GbxQ42XOEEzXjiIXeAjGQFmEVtTIOalSbZ5TFVJF1OGWlKU=
=peoP
-----END PGP SIGNATURE-----
--=-=-=--