Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B6072429E3B for ; Mon, 16 Jan 2012 03:18:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MkLnC6AvGm6K for ; Mon, 16 Jan 2012 03:18:55 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 03A50431FC0 for ; Mon, 16 Jan 2012 03:18:54 -0800 (PST) Received: by werh12 with SMTP id h12so1332391wer.26 for ; Mon, 16 Jan 2012 03:18:53 -0800 (PST) Received: by 10.216.135.30 with SMTP id t30mr4824649wei.23.1326712732301; Mon, 16 Jan 2012 03:18:52 -0800 (PST) Received: from localhost ([109.131.75.86]) by mx.google.com with ESMTPS id fg15sm21862430wbb.7.2012.01.16.03.18.51 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 03:18:51 -0800 (PST) From: Pieter Praet To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'. In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org> References: <1325004434-24583-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+78~g6c58370 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Mon, 16 Jan 2012 12:17:03 +0100 Message-ID: <87aa5nlwwg.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 11:18:55 -0000 On Tue, 27 Dec 2011 16:47:14 +0000, David Edmondson wrote: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- > emacs/notmuch-show.el | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 8c9d846..24f0b40 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -221,10 +221,7 @@ indentation." > (goto-char (notmuch-show-message-top)) > (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t) > (let ((inhibit-read-only t)) > - (replace-match (concat "(" > - (propertize (mapconcat 'identity tags " ") > - 'face 'notmuch-tag-face) > - ")")))))) > + (replace-match (concat "(" (mapconcat 'identity tags " ") ")")))))) > > (defun notmuch-show-clean-address (address) > "Try to clean a single email ADDRESS for display. Return > @@ -278,8 +275,7 @@ message at DEPTH in the current thread." > " (" > date > ") (" > - (propertize (mapconcat 'identity tags " ") > - 'face 'notmuch-tag-face) > + (mapconcat 'identity tags " ") > ")\n") > (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face))) > > -- > 1.7.7.3 Alas, those text properties actually *were* effective (and I liked them :) - Before: http://i.imgur.com/Ipxnm.png - After: http://i.imgur.com/XcaaF.png Peace -- Pieter