From: Mark Walters <markwalters1009@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts
In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>
References: <m3r4dtgz9k.fsf@zsu.kismala.com>
	<87fvu4fl25.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Fri, 23 Aug 2013 09:36:49 +0100
Message-ID: <87d2p44xcu.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Jameson Graef Rollins <jrollins@finestructure.net> writes:

> On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:
>> When text/html parts include images as multipart/related and the
>> text/plain alternative is used these images can be completely hidden
>> with no easy way to access them or even find out that they are there.
>>
>> Make notmuch-show-insert-part-multipart/related add buttons for all
>> parts, the first one visible the rest hidden.
>
> Hey, Istvan.  Thanks so much for this patch.  It seems to be addressing
> the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.
>
> However, the behavior of the part button that now appears seems to be a
> bit strange.  Clicking/hitting enter on the part attempts to save it
> rather than open it.  I wouldn't be surprised if has nothing to do with
> the correctness of this patch, though.  So is it possible that the
> button is not inserted in the most ideal way, or is there some other
> issue preventing it from behaving properly (could it have to do with the
> part being "inline"?)?


Hi

I think I have diagnosed this bug. There is a potential fix in
id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com 

The bug is nothing to do with Istvan's patch: his patch just triggers the
underlying bug in the lazy part handling.

Best wishes

Mark