Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 36865431FB6 for ; Sun, 24 Mar 2013 19:15:58 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u+0dOWHEnaqX for ; Sun, 24 Mar 2013 19:15:57 -0700 (PDT) Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU [18.7.68.35]) by olra.theworths.org (Postfix) with ESMTP id 3C78B431FAF for ; Sun, 24 Mar 2013 19:15:57 -0700 (PDT) X-AuditID: 12074423-b7f5b6d000007e03-b6-514fb35cb4ce Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id 43.EA.32259.C53BF415; Sun, 24 Mar 2013 22:15:56 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r2P2FsSC012156; Sun, 24 Mar 2013 22:15:56 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r2P2FpOR007754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 24 Mar 2013 22:15:53 -0400 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1UJwwx-0002Ao-Ej; Sun, 24 Mar 2013 22:15:51 -0400 Date: Sun, 24 Mar 2013 22:15:51 -0400 From: Austin Clements To: Tomi Ollila Subject: Re: [PATCH 1/2] emacs: Add notmuch-combine-face-text-property-string Message-ID: <20130325021551.GA32584@mit.edu> References: <1364038194-19856-1-git-send-email-damien.cassou@gmail.com> <1364038194-19856-2-git-send-email-damien.cassou@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IRYrdT0Y3Z7B9o8PCWpsWuu1uZLK7fnMls 8WblPFYHZo+ds+6yexz+upDF49mqW8wBzFFcNimpOZllqUX6dglcGVvPLGUs2M5dsav3B2MD 40zOLkZODgkBE4nzT9uYIWwxiQv31rN1MXJxCAnsY5S4OPchK4SzkVHi57wZUM5pJomlTxez QDhLGCV2T3/KAtLPIqAqsWI+hM0moCGxbf9yRhBbREBF4kHbelYQm1nARWJv+1kmEFtYwFdi //PLQDUcHLwCOhInvkRAzFzNKLH1RT/YTbwCghInZz5hgejVkrjx7yUTSD2zgLTE8n8cIGFO AQOJnRcbwMaLAq2acnIb2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqR rplebmaJXmpK6SZGcLC7KO9g/HNQ6RCjAAejEg+vQI1/oBBrYllxZe4hRkkOJiVR3v9rgEJ8 SfkplRmJxRnxRaU5qcWHGCU4mJVEeE+uB8rxpiRWVqUW5cOkpDlYlMR5r6Xc9BcSSE8sSc1O TS1ILYLJynBwKEnwZm4CahQsSk1PrUjLzClBSDNxcIIM5wEaXghSw1tckJhbnJkOkT/FqCgl zmsJkhAASWSU5sH1wpLRK0ZxoFeEeVtAqniAiQyu+xXQYCagwe69PiCDSxIRUlINjDW271Ms rJ8UGPS9C3FZ9nXajznBa68VfV6ut3DvTstw82fTOk/oS/OfnR7eNVfV8t1SObE7/x/0a7jk 96gK5Ig0mJzczPTwvSnjn71XJ7986hT18xb3gkzjua8v7GD8FfXnwPbJ/woWcT09tsMk/PP6 pxNZXFM+xhxqzwuayrfg7afC3R6Gu6OVWIozEg21mIuKEwGIiB6sIQMAAA== Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 02:15:58 -0000 Quoth Tomi Ollila on Mar 23 at 1:42 pm: > On Sat, Mar 23 2013, Damien Cassou wrote: > > > Signed-off-by: Damien Cassou > > --- > > The function notmuch-combine-face-text-property-string is used only > once in next patch. Do you anticipate more uses of it in the future? It seems like a logical helper to notmuch-combine-face-text-property, even if it's currently used in only one place. > Tomi > > > emacs/notmuch-lib.el | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el > > index e6edb9a..78c578f 100644 > > --- a/emacs/notmuch-lib.el > > +++ b/emacs/notmuch-lib.el > > @@ -357,6 +357,14 @@ OBJECT." > > (setq pos next)))) > > object) > > > > +(defun notmuch-combine-face-text-property-string (string face &optional below) > > + (notmuch-combine-face-text-property > > + 0 > > + (length string) > > + face > > + below > > + string)) > > + > > (defun notmuch-logged-error (msg &optional extra) > > "Log MSG and EXTRA to *Notmuch errors* and signal MSG. > > > > > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch