From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4] Mailstore abstraction v4
In-Reply-To: <1270737766-29237-1-git-send-email-sojkam1@fel.cvut.cz>
References: <1270737766-29237-1-git-send-email-sojkam1@fel.cvut.cz>
Date: Tue, 13 Apr 2010 11:43:49 -0700
Message-ID: <874ojfkxay.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Thu,  8 Apr 2010 16:42:42 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> My biggest question relates to the first patch, which does an
> incompatible change to libnotmuch API. After reading RELEASING file, I
> found that this change is probably not what Carl wants to merge (and I
> understand that) so I'd like to get some feedback on my suggestion in
> that patch.

[I composed this message a while ago, but failed to get it through the
mailing-list moderation until now. It may be largely irrelevant in light
of my more recent review of the mailstore abstraction, but here it is.]

I haven't looked closely at the implementation here, but a quick glance
at the API/ABI change suggests an easy answer:

Why not just add a new function that accepts the mailstore type, and
preserve the original function, (which would then simply call the new
function with an argument of "files" for the mailstore type).

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxLtl6JDdNq8qSWgRAq/HAKCpoJ0ZmZyX+nfCBP+ac4c4rCjQBwCcDgCB
WVWqSX84e7kmKric4oh61bw=
=SfO8
-----END PGP SIGNATURE-----
--=-=-=--