From: David Bremner <david@tethera.net>
To: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] Fixed warnings for test/symbol-test.cc.
In-Reply-To: <1322218492-8300-2-git-send-email-aidecoe@aidecoe.name>
References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
	<1322218492-8300-2-git-send-email-aidecoe@aidecoe.name>
User-Agent: Notmuch/0.10~rc1+12~g53b921d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 25 Nov 2011 09:07:13 -0400
Message-ID: <8762i8bbb2.fsf@convex-new.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>
Precedence: list

On Fri, 25 Nov 2011 11:54:52 +0100, Amadeusz =C5=BBo=C5=82nowski <aidecoe@a=
idecoe.name> wrote:
> ---
> +  //notmuch_database_t *notmuch =3D
> +  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);

Leaving commented out code in is for people without version control ;).

Shouldn't this cast to void?

>=20=20
>    try{
> -    (void)new Xapian::WritableDatabase ("./nonexistant",					Xapian::DB_=
OPEN);
> +    (void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN=
);

This seems to be whitespace only?  I'm not against whitespace cleanup,
but please put it in seperate commits. Or am I staring past a real
change here?

d