To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't signal an error when reaching the end of the
	search results.
In-Reply-To: <yf662h0mo6y.fsf@taco2.nixu.fi>
References: <1324370714-28545-1-git-send-email-dme@dme.org>
	<yf662h0mo6y.fsf@taco2.nixu.fi>
User-Agent: Notmuch/0.10.2+137~gc71852b (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 29 Dec 2011 08:46:32 +0000
Message-ID: <cunsjk3rcif.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 28 Dec 2011 22:33:09 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Tue, 20 Dec 2011 08:45:14 +0000, David Edmondson <dme@dme.org> wrote:
> > With the default configuration ('space' moves through the messages
> > matching the search and back to the results index at the end) it's
> > unnecessary to signal an error when the last message has been read, as
> > this is the common case.
> >=20
> > Moreover, it's very annoying when `debug-on-error' is t.
> > ---
>=20
> I'd say '+1' but I could not reproduce the case.

That's puzzling. Without the patch, if you hit 'space' on the last
message in a `notmuch-show' buffer that is the last thread in a
`notmuch-search' buffer, you should see the error when you are returned
to the `notmuch-search' buffer. Does that not happen?

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk78KOgACgkQaezQq/BJZRbZ1gCeOHqDOF5AItYNyel4VhRMOWND
zGIAnj5kNf+kCfFzLz83xCAETuAb3Gx+
=fFw/
-----END PGP SIGNATURE-----
--=-=-=--