From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, Peter Feigl <craven@gmx.net>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v4 3/5] Use the S-Expression structured printer in
	notmuch-show, notmuch-reply and notmuch-search.
In-Reply-To: <87txry5m08.fsf@qmul.ac.uk>
References: <cover.1354794428.git.craven@gmx.net>
	<9cb474a271c471f8bae8b55b0148bb970ba78ceb.1354794428.git.craven@gmx.net>
	<871uf2in54.fsf@servo.finestructure.net>
	<87txry5m08.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.14+143~g175686e (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 07 Dec 2012 00:24:36 -0800
Message-ID: <87mwxqgth7.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain

On Fri, Dec 07 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Jameson Graef Rollins <jrollins@finestructure.net> writes:
>
>> On Thu, Dec 06 2012, Peter Feigl <craven@gmx.net> wrote:
>>> -    /* Any changes to the JSON format should be reflected in the file
>>> -     * devel/schemata. */
>>> +    /* Any changes to the JSON or S-Expression format should be
>>> +     * reflected in the file devel/schemata. */
>>
>> Can we just make these comments more general, so we don't have to tweak
>> them every time a new formatter is added?
>
> I think I agree, but I think it may as well wait until we have more than
> the two formats. In other words I would suggest not holding up the
> (latest version) of this series for this.

Yes, that's totally fair.  I didn't notice later that a new version of
the patch had already been sent.

I haven't had a chance to review the patches, but I am certainly all for
the feature.  Definitely don't hold it up on this account.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQwafEAAoJEO00zqvie6q87O8P/A80+dLNpZ3M9nDNl9aV1TZW
XV6m8wWrDi2pz8FHaZQ4en0Y0dwJ/t2rCCMN2bPEieLZrgm+ktd3LU7jY/pkYBip
Q1DJsHw41HiPTz9O0bSremCa2U+GzJ5iXyP/euHnRcm6Q4cppqJDQ8btDWA9zc7Z
zg7g24/pXS9DSxwMbFcGnU/aMJWYwr8JtOWEFBaHANeTqd5WdE9uzG6N9q3tSrcI
nUqRjqLjI7SVy0u/Rw32j0LsGg8UNIO8zvVuBwHU+dO3AdQI2OUzJVyaP2NFoGXd
tV40Qzn3/XQkS6OkIkkwGeJb5UrhpvrrSjaSdfqfj1lAjyYL/vxg4viX/LGR16KP
YvN9NldyvKUzgJHfAuO5Lv0FWyWiPiI3ZGoL3xLmHH4A+O/1Ap9HUSfAcVy7/xRJ
Yq+JMagdfg0g/whVteEFtTswxbRBWKB7KWQV7k5gNfKQiTPttkNqvZB1odrRu97H
s2FqyBhE3y9pOmqqRDcE6KiPfHQLx3KHmkYajqOFHD0u6A0Sr8v+PD/kUfOGFNXz
SSPwNwtR2jbm7CLLRhg0Pxdto8v4GxJkG6sLTdc1hk0Du9JBzw6XEBgv31syRJe9
kfQBoGbye2ESQ+kfAveXiiD6Jw4kjUFu8W1KaLhdE8rjUeTNPfzVqbcNAnQn4cU0
jcf436O/Ljlhm4NlYutJ
=YxVI
-----END PGP SIGNATURE-----
--=-=-=--