Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 15E9E431FD2 for ; Tue, 24 Jan 2012 11:52:18 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mbCvtMiXKT92 for ; Tue, 24 Jan 2012 11:52:16 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 025F7431FB6 for ; Tue, 24 Jan 2012 11:52:15 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 7A77866E01B1; Tue, 24 Jan 2012 11:52:15 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 7EF6A66E01A4; Tue, 24 Jan 2012 11:52:12 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 184E02CE; Tue, 24 Jan 2012 11:52:12 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327409620-10133-1-git-send-email-dme@dme.org> <1327409620-10133-2-git-send-email-dme@dme.org> <87k44hym3i.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Jan 2012 11:52:09 -0800 Message-ID: <87bopszxna.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 19:52:18 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 24 Jan 2012 19:25:19 +0000, David Edmondson wrote: > On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins wrote: > > Is there a reason it's really necessary to make this change? Can't > > callers just ignore the returned button if they don't care about it > > further? I can see that maybe it's nice to be able to specify > > parameters at creation time, but I'm not sure why that requires throwing > > out the returned object as well. >=20 > Patches 2 and 3 in that series can result in the button not being > inserted. Can patches 2 and 3 be rewritten so they are compatible with the button being returned by the button creation function? jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPHwvpAAoJEO00zqvie6q8qvwP/2CNuDgzHGQDYCakv5z3JWFd BBx1azQw41ElwPOmQ/+GyEIJKeU+VqapJmYFyW4tnzI40428Z6lPHJAWgxFnydBT JM9hM7XZpUh8vhJz3If4QdSa+5m26hK57FhkMlNdKARbtCTd/PZXJYsrooPmPE/L OrYIxUlI3j2/nBYlTqtkbQPk3siPuFTJNOLxF26hon6oHZPGVtvHNpTZD7aLRa25 iAJYoq42tFhRJl2weMtFLMXprIJ/V/Kke1KHL7M9zNM1dsjhmlPzSb0HO7HrCrd+ NauHoLl3XdwkjIGti83sECpx7oRaQtVY7MW8RnQOck4dGeTRTTWOSXEMtqH3ZNpm KpJa7Y4rRtfGKwwAZQ/04epcqfbo3P6SIGYsCcUtwulWaL7w3llVM5ik/+rau8YL s4ovNyWQl7Rb/rk0Lj70us01VfspePSJj4PSvdLgvHca8bdHAPLrDrUM8G6qEu76 yBgPTzUUVpcq2VPZoS+Q+3CwUb/O/z2YKO+DgiVDk9Pq5NoBUcllNbK8t3kgYfFV eIip3KL7HMh0kz6FkqBUQQ1iBizsfP+IFCgEPDptjKlZ6UckpaLOOdubkiGgozby mJx/4wuwyPnUNCpdd7uokoTNnj9MPrGiWEID4BRiIdg7JSsTHO8dMXJdon9iDpcf PhRdZjDMO7pPKeqObmTJ =Yqvf -----END PGP SIGNATURE----- --=-=-=--