From: Carl Worth <cworth@cworth.org>
To: Jjgod Jiang <gzjjgod@gmail.com>, notmuch@notmuchmail.org
In-Reply-To: <ddd65cda0911171950o4eea4389v86de9525e46052d3@mail.gmail.com>
References: <ddd65cda0911171950o4eea4389v86de9525e46052d3@mail.gmail.com>
Date: Wed, 18 Nov 2009 23:27:20 +0100
Message-ID: <874oorfozb.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [notmuch] Mac OS X/Darwin compatibility issues
Precedence: list

On Wed, 18 Nov 2009 11:50:17 +0800, Jjgod Jiang <gzjjgod@gmail.com> wrote:
> 1. g++ reports 'warning: command line option "-Wmissing-declarations"
> is valid for C/ObjC but not for C++'

In cairo, what we do is have a huge list of desired warnings and then
test each one in turn with a test-compile in the configure script.
That's probably what we should do here, (I recently established a
Makefile.config for this purpose that should be generated by the
configure script.)

> 2.
> notmuch-reply.c: In function =E2=80=98address_is_users=E2=80=99:
> notmuch-reply.c:87: warning: passing argument 2 of
> =E2=80=98notmuch_config_get_user_other_email=E2=80=99 from incompatible p=
ointer type

Thanks for the report. I think I saw a fix for this in a commit from
Chris Wilson that's in my queue. (Though from a quick glance I'm not
sure where the size_t type got started in the code and propagated
throught this part).

> 3. Several errors about missing GNU extensions like getline() and strndup=
():
>=20
> warning: implicit declaration of function =E2=80=98getline=E2=80=99
> error: =E2=80=98strndup=E2=80=99 was not declared in this scope
>=20
> We can implement these with fgets() and strncpy() though.

Yes. I knew I was "cheating" by using some GNU extensions here. I'm
happy to accept portability patches for these things, but it's hard for
me to get excited about writing them myself.

Care to take a whack at these?

-Carl