Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7FDD740D149 for ; Fri, 29 Oct 2010 16:17:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ye2zbBLsF6v5 for ; Fri, 29 Oct 2010 16:17:06 -0700 (PDT) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) by olra.theworths.org (Postfix) with ESMTP id 98DC240D162 for ; Fri, 29 Oct 2010 16:16:57 -0700 (PDT) Received: by fxm6 with SMTP id 6so3893397fxm.26 for ; Fri, 29 Oct 2010 16:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=/mAGuxVSR3krzQqrDVOY6fC8goKgTvbx8B7+zEonDCo=; b=Oqm+WgYzt117COwSFzS1yVUDWpq8pyOEj033WLuOij9QQWqb6bfhon8bbtCjb1fldA YOJcE9Ph8gk+GtJ9+pxMt9C9Hz55TbjRP1TpDA18t4w14AC+HS3qliFgLgOVrTn8uOCy RQL6EtXQDEQ2wXJI1lemrD49WAQlGDrWJGFDM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Yxxb/qmR2shu+lb2J8MiLY9AsgRyZVSXksCe15NXnOpqToCwd9fZseQ3SGuv6huy8X T7zNq84+Dr1MdPra33dnflLf4jLeXlRNqFBSHnDR5MDFI7age7XVu0ZSNuKeFoJa9dVq eDKj12oXYsbI2qf2ri/mDJmBGZzFUHJr0MQho= Received: by 10.223.78.143 with SMTP id l15mr1145794fak.30.1288394216922; Fri, 29 Oct 2010 16:16:56 -0700 (PDT) Received: from localhost (a91-153-253-80.elisa-laajakaista.fi [91.153.253.80]) by mx.google.com with ESMTPS id m8sm1306399faj.11.2010.10.29.16.16.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 29 Oct 2010 16:16:56 -0700 (PDT) From: Felipe Contreras To: notmuch@notmuchmail.org Subject: [PATCH 1/2] build: fix DSO dependencies Date: Sat, 30 Oct 2010 02:16:46 +0300 Message-Id: <1288394207-10223-2-git-send-email-felipe.contreras@gmail.com> X-Mailer: git-send-email 1.7.3.2.2.g0dc5c In-Reply-To: <1288394207-10223-1-git-send-email-felipe.contreras@gmail.com> References: <1288394207-10223-1-git-send-email-felipe.contreras@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2010 23:17:16 -0000 From: Carl Worth At least on Fedora 13, this doesn't link; the linker finds the dependencies, and aborts saying we should include them. /usr/bin/ld: gmime-filter-reply.o: undefined reference to symbol 'g_mime_filter_set_size' /usr/bin/ld: note: 'g_mime_filter_set_size' is defined in DSO /usr/lib/libgmime-2.6.so.0 so try adding it to the linker command line /usr/lib/libgmime-2.6.so.0: could not read symbols: Invalid operation We do need to link at least to what we really use, the linker resolves the dependencies of our dependencies at loading time. For more information, see: https://fedoraproject.org/wiki/UnderstandingDSOLinkChange Reported by Felipe Contreras, rewrote by Carl Worth. Signed-off-by: Felipe Contreras --- Makefile.local | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index bc61a3c..9fed725 100644 --- a/Makefile.local +++ b/Makefile.local @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc # Smash together user's values with our extra values FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags) FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS) FINAL_NOTMUCH_LINKER = CC ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) -- 1.7.3.2.2.g0dc5c