Date: Wed, 24 Sep 2014 14:39:10 -0700
From: "W. Trevor King" <wking@tremily.us>
To: Austin Clements <aclements@csail.mit.edu>
Subject: Re: [PATCH v3] lib: Simplify close and codify aborting atomic section
Message-ID: <20140924213910.GF20130@odin.tremily.us>
References: <20140924212839.GE20130@odin.tremily.us>
	<1411594370-9794-1-git-send-email-aclements@csail.mit.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="/aVve/J9H4Wl5yVO"
Content-Disposition: inline
In-Reply-To: <1411594370-9794-1-git-send-email-aclements@csail.mit.edu>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--/aVve/J9H4Wl5yVO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 24, 2014 at 05:32:50PM -0400, Austin Clements wrote:
> + * If the caller is currently in an atomic section (there was a
> + * notmuch_database_begin_atomic without a matching
> + * notmuch_database_end_atomic), this will abort the atomic section,
> + * discarding any modifications made in the atomic section.  All
> + * changes up to this will be committed.

I still think Xapian's wording is more readable [1]:

  For a WritableDatabase, if a transaction is active it will be
  aborted, while if no transaction is active commit() will be
  implicitly called.

How about:

  For a writable database, if a transaction is active (there was a
  notmuch_database_begin_atomic without a matching
  notmuch_database_end_atomic) it will be aborted, while if no
  transaction is active any pending changes will be committed.

Cheers,
Trevor

[1]: http://xapian.org/docs/apidoc/html/classXapian_1_1Database.html#a59f5f=
8b137723dcaaabdbdccbc0cf1eb

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--/aVve/J9H4Wl5yVO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIbBAEBAgAGBQJUIzn8AAoJEG8/JgBt8ol8SQYP9ihcFBhpSiczMQM0iTuPKBrV
cc6qh6KnQLf9U6BZDbFEO5Jf1jfk+y1j96229gwMYf7PXYPLXTyRX7tl4/8qNAQr
9FDB/ChBUJNgSAONEVDdVMEAmkxKXf0XUoATrduhKT1gljlGLxcobqrp2/deCxny
BHcGXLOqo2U8vtBlqRfqxE+4pm0y6bINQ6U5JXhiw5IYZMyyE3d7WgsPSFn0clFc
/+BagDpqd+TGYvlT/A7htXBaUrqjCEOfX31JfblrmM50YXiHFPpEHSF/aFCUchT8
FTLHuFXZemvHNeBbdTTR8PhdZJsDXM1ghDn4/CyMltwjNuKhnxlQ2YVWpiXhgfX6
p180/p20WdJtr5O96c/SoYRbfqVhmuBegv+s59EcS4t3zbjDxJQ4LR+BaVyip1TZ
UEwVc2MLYTF8nqlJcn5elbe7Xmh50q8mwh098cYbVh03DNlPJUvSRmBkYrjf2opN
sTVnW4WwA7YcNdChsxami2bCr1umRPNDEwuEs937+MtWTVAtyM2TUIXRqqxxAu6v
4uME+xIZgPdEljktlwk7KvBGSf4ABD1uZdFr7wVONiFsvFsg1pP91JJ+bDDgOXBv
HRzxqqq9wosDxbHXtKNQVIMvGYZUfiWikzGwvMTYyRGH5I7c3FcVS2+Tbrmkwe8s
+DSeIXNIk6nxvyC51c4=
=foFN
-----END PGP SIGNATURE-----

--/aVve/J9H4Wl5yVO--