From: Tomi Ollila <tomi.ollila@iki.fi>
To: Blake Jones <blakej@foo.net>
Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output
	(Solaris support)
In-Reply-To: <24582.1352356152@foo.net>
References: <24582.1352356152@foo.net>
User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 08 Nov 2012 10:55:36 +0200
Message-ID: <m2bof8fp87.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote:

>>> @@ -11,10 +12,44 @@ fi
>>>  HEADER=$1
>>>  shift
>>>  
>>> +if [ `uname -s` == SunOS ] ; then
>>> +    #
>>> +    # Using Solaris "nm", a defined symbol looks like this:
>>> +    #
>> 
>> The POSIX / Bourne -comformant equality comparison is '='. 
>
> Sigh, of course it is.  Fixed.
>
>> e.g.
>> 
>> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x'
>> ./heirloom-sh/sh: test: unknown operator ==
>> zsh: exit 1     ./heirloom-sh/sh -c ' [ a == b ] || echo x'
>> 
>> Interesting that Solaris /bin/sh did not fail there...
>
> I was running on Solaris 11.1, which uses ksh93 as its /bin/sh.  You're
> absolutely right that Solaris 10 would fall over, though.
>
> Similarly, the following line:
>
>     demangled=$(demangle $sym)
>
> doesn't work on traditional sh.  I've replaced $() with ``.
>
>> Hmm, gen-version-script doesn't have shebang... it is run like:
>> 
>> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@
>> 
>> in lib/Makefile.local -- taking sh fron PATH.
>
> I updated the first line from the #! invocation to a comment saying
>
>     # This script is invoked via "sh .../gen-version-script.sh".

looks good

> Would a respun version of these patches help toward testing?

$ grep vim test/*
zsh: exit 1     grep vim test/*

i.e. no vim tests...

Also, as *I* will execute my tests in Linux these won't make things
fail -- and probably no-one else eager to test won't have problems
either

So I think these patches are good until someone(tm) finds other
issues (if any),

> Blake

Tomi