Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 58A1B431FB6 for ; Tue, 4 Sep 2012 02:13:29 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pfS0mxvTDn7W for ; Tue, 4 Sep 2012 02:13:28 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 420E6431FAF for ; Tue, 4 Sep 2012 02:13:28 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id A037D1000E5; Tue, 4 Sep 2012 12:13:34 +0300 (EEST) From: Tomi Ollila To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Add customization group for replying In-Reply-To: <87vcfu2qap.fsf@steelpick.2x.cz> References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz> <87vcfu2qap.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 09:13:29 -0000 On Tue, Sep 04 2012, Michal Sojka wrote: > On Thu, Jul 26 2012, Michal Sojka wrote: >> When one wants to customize the format of reply message, there nothing >> to tell the user how to do it. Without knowing that construction of >> reply buffer is actually implemented in the message package, it seems >> that replying cannot be customized. >> >> Because I was getting annoyed by the empty line the between citation >> line and the quoted message, I figured out that changing this is fairly >> easy when one knows what to customize. >> >> This patch adds notmuch-reply customization group that that contains >> references to the relevant customization options. The new group is easy >> to find as it is shown as a result of running "M-x customize-group RET >> notmuch RET". > > Ping. > > Any objections against applying? Nobody dares to say anything due to infamiliriaty of this spesific case ;/. I could not find any reference this has been made before. I could not find any discussion about this issue. With little effort I could not extract the customization tree to stdout I could have attempted to grep whether there is same variable in many groups. The code in custom.el & cus-edit.el is so complex I could not figure out whether there is any problems having variable in many groups (put apparently the changed variable is not written twice to the customization block). I do like the feature but with this knowledge I have I just cannot promote applying (I sure am not against :) > -Michal Tomi