Return-Path: <dmitry.kurochkin@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id CA5B5431FD0
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:22:46 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level: 
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id iHd6yl8bP54W for <notmuch@notmuchmail.org>;
	Thu,  7 Jul 2011 01:22:46 -0700 (PDT)
Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
	[209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id EF1C1431FB6
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:22:45 -0700 (PDT)
Received: by bwg12 with SMTP id 12so754056bwg.26
	for <notmuch@notmuchmail.org>; Thu, 07 Jul 2011 01:22:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	bh=mZ2yVBvJ4jyC9g1j9wmxV6GrMtxARWsA4+IVZM0qI/s=;
	b=kFB4LapKZ+r57G17VxoE9K2gVmXwafthH/zlCT4UQBpkGDFglj5Yn7VM80QtsTfxAx
	TG8aQ65SgCedzHh7GZKaUjbWyxowJCgUax7BnEeL3YuTVN0Bi1qG/hQzEG/K3cXGyd4e
	UoJLZnUuWraFE0UjQ5MCC+WAST7m9aFkhYL1M=
Received: by 10.204.84.24 with SMTP id h24mr439822bkl.185.1310026964524;
	Thu, 07 Jul 2011 01:22:44 -0700 (PDT)
Received: from localhost ([91.144.186.21])
	by mx.google.com with ESMTPS id c13sm8294399bkc.2.2011.07.07.01.22.42
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 07 Jul 2011 01:22:43 -0700 (PDT)
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Daniel Schoepe <daniel.schoepe@googlemail.com>,
	Pieter Praet <pieter@praet.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons
	for notmuch searches
In-Reply-To: <87vcve1p70.fsf@tredergarh.home.box>
References: <1309896760-378-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-2-git-send-email-daniel.schoepe@googlemail.com>
	<87r5624l3g.fsf@gmail.com> <87vcve1p70.fsf@tredergarh.home.box>
User-Agent: Notmuch/0.5-321-g41686e2 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 07 Jul 2011 12:22:37 +0400
Message-ID: <87ipre4i0i.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2011 08:22:46 -0000

On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> Hi Dmitry,
> 
> On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Why do we need to remove `goto-address-mode' overlays if it is not
> > enabled ((goto-address-mode t) is below is removed)?
> > [..]
> > `goto-address-mode' creates buttons not only for email addresses but
> > also for URLs.  Do we loose it now?
> 
> Everything `goto-address-mode' does is still in effect, I just replaced
> (goto-address-mode t) by a call to `goto-address-fontify-region' in
> notmuch-show-buttonise-links, to ensure that the id links will be
> buttonised (and the overlay removed after it's actually been inserted)
> _after_ goto-address does its thing.
> 
> I could also have left (goto-address-mode t) in and jit-register-lock'ed
> notmuch-show-buttonise-links before that, but then I would be relying on
> the fact that fontifiers that are registered first, will be run last. As
> far as I can tell this is just an implementation detail and might change
> some day.
> 

Thank you and Pieter for the answers.  I missed
`goto-address-fontify-region' on the first look.

Regards,
  Dmitry

> Cheers,
> Daniel