Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5B5A7431FC4 for ; Sun, 15 Apr 2012 10:39:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XsTqX9AysEtV for ; Sun, 15 Apr 2012 10:39:15 -0700 (PDT) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id 3E448431FBD for ; Sun, 15 Apr 2012 10:39:15 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 476AD68055; Sun, 15 Apr 2012 20:39:12 +0300 (EEST) From: Tomi Ollila To: Mark Walters , Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name. In-Reply-To: <87iph06h72.fsf@qmul.ac.uk> References: <87vcoaywyu.fsf@servo.finestructure.net> <1326826969-23545-1-git-send-email-jrollins@finestructure.net> <87iph06h72.fsf@qmul.ac.uk> User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2012 17:39:16 -0000 On Sun, Apr 15 2012, Mark Walters wrote: > On Tue, 17 Jan 2012, Jameson Graef Rollins wrote: >> No functional change here. The help message previously referred to >> the "delete" tag, but "deleted" is now preferred, so hopefully this >> will reduce any potential confusion. > > This patch is trivially correct regardless of the rest of the > series. Agreed. +1 > > I think the rest of the series (which provides keybindings for > adding/removing the delete tag to messages/threads) is worthwhile > particularly now the exclude stuff is fairly complete (feedback at the > time looked positive). > > Patch 2/3 needs simple but genuine rebasing as the names of the > tagging functions have changed though. Why not :) > > Best wishes > > Mark Tomi > >> --- >> emacs/notmuch.el | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el >> index e4bca51..67ecd3a 100644 >> --- a/emacs/notmuch.el >> +++ b/emacs/notmuch.el >> @@ -660,12 +660,12 @@ This function advances the next thread when finished." >> Here is an example of how to color search results based on tags. >> (the following text would be placed in your ~/.emacs file): >> >> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\" >> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\" >> :background \"blue\")) >> (\"unread\" . (:foreground \"green\")))) >> >> The attributes defined for matching tags are merged, with later >> -attributes overriding earlier. A message having both \"delete\" >> +attributes overriding earlier. A message having both \"deleted\" >> and \"unread\" tags with the above settings would have a green >> foreground and blue background." >> :type '(alist :key-type (string) :value-type (custom-face-edit)) >> -- >> 1.7.7.3 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch