From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, Gregor Hoffleit <gregor@hoffleit.de>,
	notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] First tests for JSON output and UTF-8 in mail body and
	subject
In-Reply-To: <87ochlt8r9.fsf@steelpick.2x.cz>
References: <1267697893-sup-4538@sam.mediasupervision.de>
	<87r5mje55l.fsf@yoom.home.cworth.org>
	<1271176622-sup-4680@sam.mediasupervision.de>
	<87iq7tft7j.fsf@yoom.home.cworth.org>
	<87ochlt8r9.fsf@steelpick.2x.cz>
Date: Thu, 15 Apr 2010 12:58:58 -0700
Message-ID: <878w8ofpx9.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Thu, 15 Apr 2010 10:33:46 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> are you still interrested in modular test suite from git? If so, could
> you please look at id:87mxxg7bxo.fsf@steelpick.2x.cz and tell me your
> opinion. I'm still updating the modularized tests to match the state in
> master but every change in master takes me quite long time to convert.

Hi Michal,

I would still like to have a modular test suite, yes.

Thanks for pointing out that other message to me, which I had missed in
the general notmuch-mailing-list backlog I'm still dealing with. I've
now replied to it over there.

I am sorry that you keep having to re-do a bunch of work to keep your
patch up-to-date. I'm just about to push another change which might
further cause problems.

But you might actually like that change since it's one you requested in
your first version of the modular test suite. I'm dropping the annoying
execute_expecting macro that both runs notmuch and tests the
output. There's now a much cleaner separation such as:

	output=$($NOTMUCH search for-something)
	pass_if_equal "$output" "something was found"

I still think it wouldn't be hard to just gradually implement any
particular features we want in the test suite. But if the git thing ever
does become available, then that will be fine too.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLx3AC6JDdNq8qSWgRArmsAJ0SiANOlj2/5U1OB28QzBF4BofW3wCgqe3X
A/yQ1ZrAJm3WNY46Hsq6M3k=
=FZsB
-----END PGP SIGNATURE-----
--=-=-=--