From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Jani Nikula <jani@nikula.org>, Adrien Bustany <adrien@bustany.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t
In-Reply-To: <87vce7yllt.fsf@nikula.org>
References: <1342723401-26103-1-git-send-email-adrien@bustany.org>
	<1350510742-13447-1-git-send-email-adrien@bustany.org>
	<87vce7yllt.fsf@nikula.org>
User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 20 Oct 2012 11:49:04 -0400
Message-ID: <87y5j15ekv.fsf@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

Jani Nikula <jani@nikula.org> writes:

> On Wed, 17 Oct 2012, Adrien Bustany <adrien@bustany.org> wrote:
>> The code of the patches in unchanged, but the formatting issues are now
>> hopefully fixed.
>
> Hi Adrien, please check at what version flush and reopen have been
> introduced to xapian. If they are new-ish (I don't know, didn't have the
> time to check), please add appropriate #ifdefs. [1] lays the groundwork
> for this. We'll also need to decide what is the minimum xapian version
> required in general, i.e. features earlier than that don't need
> conditional compilation.

Hi! The new versions of these patches are still pretty trivial and they
still look OK to me, but based on Jani's prompting I decided to look up
the methods. Seems that flush() is a very old (pre-1.1.0, 2009-04) name
for commit(), which is the preferred name these days. You should
probably therefore rename the function notmuch_database_commit, and have
it call the WritableDatabase::commit() method.

reopen() is a very very old method, seems like it has been around since
2004.

So I think Adrien is safe from having to do version checks, but we
should probably use commit() instead of flush().

Ethan